This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement basic text rendering support in CanvasKit backend #13903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Nov 19, 2019
| /// CanvasKit does not yet allow us to specify family names when registering | ||
| /// fonts. CanvasKit reads the font name from the font's bytes. So, we map | ||
| /// some common family names to how they are registered in the Gallery app. | ||
| const Map<String, String> _fontFamilyOverrides = <String, String>{ |
There was a problem hiding this comment.
Let's leave a TODO to clean this up.
| class SkParagraph implements ui.Paragraph { | ||
| SkParagraph(this.skParagraph, this._textDirection, this._fontFamily); | ||
|
|
||
| final js.JsObject skParagraph; |
There was a problem hiding this comment.
What is the lifecycle of this object? Does it need to be deallocated?
There was a problem hiding this comment.
Developers can hold onto it and keep using it with Canvas.drawParagraph if they wish. We can, however, clean up ParagraphBuilder after build is called.
| try { | ||
| skParagraph.callMethod('layout', <double>[constraints.width]); | ||
| } catch (e) { | ||
| html.window.console.warn('CanvasKit threw an exception while laying ' |
There was a problem hiding this comment.
This should fail harder, no?
There was a problem hiding this comment.
Changed to rethrow
| canvasKit['ParagraphBuilder'].callMethod('Make', <js.JsObject>[ | ||
| skStyle.skParagraphStyle, | ||
| skiaFontCollection.skFontMgr, | ||
| ]); |
There was a problem hiding this comment.
nit: I think a trailing comma will allow dartfmt do a better job here.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2019
tvolkert
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 20, 2019
* f240462 Implement basic text rendering support in CanvasKit backend (flutter/engine#13903) * ffcd856 Imagefilter wrapper object (flutter/engine#13711) * 176f563 Roll src/third_party/dart eeca3fb1cb..1f933abcee (7 commits) (flutter/engine#13931)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic text rendering support using the "SkParagraph" module in Skia.