This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Clipping path fix for browsers that don't use correct units when applying clip-path css using svg #15712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jan 17, 2020
lib/web_ui/lib/src/engine/util.dart
Outdated
| {double offsetX = 0, | ||
| double offsetY = 0, | ||
| double scaleX = 1.0, | ||
| double scaleY = 1.0}) { | ||
| _clipIdCounter += 1; | ||
| final ui.Rect bounds = path.getBounds(); |
| }); | ||
|
|
||
| // Regression test for https://github.com/flutter/flutter/issues/48683 | ||
| test('Clips triangle with oval clip path devicePixelRatio2', () async { |
There was a problem hiding this comment.
What does "devicePixelRatio2" in the description mean? I wasn't able to parse it from the test itself.
There was a problem hiding this comment.
removed. Initially explored EngineWindow.debugDevicePixelRatio but snapshots still need some infra updates as discussed.
|
Merging on red, infra failures. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 17, 2020
…hen applying clip-path css using svg (flutter/engine#15712)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 17, 2020
flutter/engine@8df1757...98c1aea git log 8df1757..98c1aea --first-parent --oneline 2020-01-17 ferhat@gmail.com Clipping path fix for browsers that don't use correct units when applying clip-path css using svg (flutter/engine#15712) 2020-01-17 dnfield@google.com fix typo, update path metrics docs (flutter/engine#15715) 2020-01-17 skia-flutter-autoroll@skia.org Roll src/third_party/dart c8f8c11b70b4..843bd2990881 (5 commits) (flutter/engine#15714) 2020-01-17 aam@google.com Roll dart to c8f8c11b70 (flutter/engine#15708) 2020-01-17 garyq@google.com Samsung fix duplication on punctuation: Update keyboard on finish compose. (flutter/engine#15701) 2020-01-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2cd5d43f022c..d58b643f10f5 (21 commits) (flutter/engine#15707) 2020-01-17 chinmaygarde@google.com Disable GPUThreadMerger tests inline instead of via harness flags. (flutter/engine#15706) 2020-01-17 dnfield@google.com implicit casts and add missing docs (flutter/engine#15698) 2020-01-17 47866232+chunhtai@users.noreply.github.com loadfontfromlist should send fontchange message to framework (flutter/engine#14805) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…ying clip-path css using svg (flutter#15712)
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…hen applying clip-path css using svg (flutter#15712)" This reverts commit 80b1162.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…ying clip-path css using svg (flutter#15712)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari requires objectBoundingBox units on svg clipPaths to function correctly, the default units don't scale correctly on these browsers when page is zoomed or used on highdpi devices.
Fixes flutter/flutter#48683