Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "Add support for the Metal backend on all iOS builds." #17191

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Reland "Add support for the Metal backend on all iOS builds." #17191

merged 1 commit into from
Mar 18, 2020

Conversation

chinmaygarde
Copy link
Member

This reverts commit ec2c624.

Fixes flutter/flutter#52577.

@chinmaygarde chinmaygarde added this to In Progress in Metal Renderer via automation Mar 18, 2020
@auto-assign auto-assign bot requested a review from gaaclarke March 18, 2020 04:22
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 18, 2020
dnfield
dnfield approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 4196207 into flutter:master Mar 18, 2020
Metal Renderer automation moved this from In Progress to Done Mar 18, 2020
chinmaygarde added a commit that referenced this pull request Mar 18, 2020
@chinmaygarde
Revert "Reland "Add support for the Metal backend on all iOS builds." (…
90f35e7 
…#17191)"

This reverts commit 4196207.
@chinmaygarde chinmaygarde mentioned this pull request Mar 18, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2020
@engine-flutter-autoroll
4196207 Reland "Add support for the Metal backend on all iOS builds." (…
94dc290 
…flutter/engine#17191)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2020
Merged
@chinmaygarde chinmaygarde deleted the symbols_leak branch July 7, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
Metal Renderer
  
Done
Milestone
No milestone
4 participants
@chinmaygarde @dnfield @googlebot @fluttergithubbot