This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement Hashcode for TextEditingValue in InputConnectionAdaptor #17643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 10, 2020
| @@ -75,6 +75,11 @@ public boolean equals(Object o) { | |||
| && composingEnd == value.composingEnd | |||
| && text.equals(value.text); | |||
| } | |||
|
|
|||
| @Override | |||
| public int hashCode() { | |||
There was a problem hiding this comment.
The pattern followed elsewhere (I looked at AccessibilityViewEmbedder.java) seems to combine the hashcode with a prime. This one looks fine to me but it may be a good idea to isolate that into a helper so this doesn't have to be reinvented.
There was a problem hiding this comment.
I'll follow the same style as AccessibilityViewEmbedder.java for now to unblock the G3 roll, but yeah, we should find a place to add prime hashing logic to share across the android embedder.
GaryQian
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 11, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The equals override requires hashcode override as well. This class is private and the hashcode is (currently) unused.