Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll src/third_party/dart 5b19445d9cb2..4814f000de2b (4 commits) #17801

Merged

Conversation

skia-flutter-autoroll
Copy link
Contributor

https://dart.googlesource.com/sdk.git/+log/5b19445d9cb2..4814f000de2b

git log 5b19445..4814f00 --date=short --first-parent --format='%ad %ae %s'
2020-04-18 scheglov@google.com Promote to NonNull of a tested type on assignment.
2020-04-18 sra@google.com [dart2js] specialize legacy primitive as-checks
2020-04-18 scheglov@google.com Change the default type of the exception to 'Object' instead of 'dynamic'.
2020-04-17 mfairhurst@google.com [nnbd_migration] fix #41391, crash applying migration.

Created with:
gclient setdep -r src/third_party/dart@4814f000de2b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com

https://dart.googlesource.com/sdk.git/+log/5b19445d9cb2..4814f000de2b

git log 5b19445..4814f00 --date=short --first-parent --format='%ad %ae %s'
2020-04-18 scheglov@google.com Promote to NonNull of a tested type on assignment.
2020-04-18 sra@google.com [dart2js] specialize legacy primitive as-checks
2020-04-18 scheglov@google.com Change the default type of the exception to 'Object' instead of 'dynamic'.
2020-04-17 mfairhurst@google.com [nnbd_migration] fix flutter#41391, crash applying migration.

Created with:
  gclient setdep -r src/third_party/dart@4814f000de2b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
@skia-flutter-autoroll skia-flutter-autoroll added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 18, 2020
@fluttergithubbot fluttergithubbot merged commit 4b91f46 into flutter:master Apr 18, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
3 participants