This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Extend external view embedder on Android #17839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Android native shell doesn't have unit tests. I filed flutter/flutter#55269. I could add one unit test to check that |
chinmaygarde
approved these changes
Apr 21, 2020
added 2 commits
April 20, 2020 21:56
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2020
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 22, 2020
* e83f30c Pass amber-files directory to tests. (flutter/engine#17815) * b1c51cf Extend external view embedder on Android (flutter/engine#17839)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wires up the external view embedder for Android, which just does the bare minimum work. It doesn't handle most of the features required in hybrid composition.
The external view embedder is used if
AndroidViewis constructed withcompositeMode: AndroidViewCompositeMode.hybridafter flutter/flutter#55175 is merged.