This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use Float32List as Matrix storage inside the Web engine #17856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
reviewed
Apr 22, 2020
| @@ -7,6 +7,19 @@ part of engine; | |||
|
|
|||
| typedef OnBenchmark = void Function(String name, num value); | |||
|
|
|||
| typedef Action<R> = R Function(); | |||
There was a problem hiding this comment.
Did you intend to have profiler.dart change in this PR ?
There was a problem hiding this comment.
I will remove it once I rebase on top of #17852. I will rebase on top of it and remove the profiler changes here. I only needed it to verify the impact of the change on preroll, where we do a ton of vector math.
| commitScene(_persistedScene); | ||
| _lastFrameScene = _persistedScene; | ||
| return SurfaceScene(_persistedScene.rootElement); | ||
| timeAction<void>('sceneBuilderPrerollFrame', () { |
There was a problem hiding this comment.
treeshake from release builds ?
There was a problem hiding this comment.
I couldn't find a way to tree-shake timeAction entirely without making the cost super-ugly. Open to ideas, but currently decided that it wasn't worth it. In release mode timeAction becomes:
R timeAction<R>(String label, Action<R> action) => action();
So the cost is one closure. Since SceneBuilder.build runs once per frame the difference is negligible.
ferhatb
approved these changes
Apr 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts all
Float64Listmatrices toFloat32Listat thedart:uiinterface boundary. Internally, it only usesFloat32List.Float32Listrequires less memory and is orders of magnitude faster to allocate, and it has sufficient precision as Flutter mobile engine and Skia use 32-bit floats anyway.This change speeds up frame preroll by 50% on the bench_card_infinite_scroll benchmark.
For more details on
Float64Arrayallocation in JS (which backsFloat64Listin Dart) see the following: