This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add FlStandardCodec #18213
Merged
robert-ancell
merged 1 commit into
flutter:master
from
robert-ancell:linux-shell-fl-standard-codec
May 11, 2020
Merged
Add FlStandardCodec #18213
robert-ancell
merged 1 commit into
flutter:master
from
robert-ancell:linux-shell-fl-standard-codec
May 11, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4103eb0
to
ffde249
Compare
51e45ce
to
3faa0d7
Compare
8b8ce2b
to
80e3f33
Compare
Does this actually need anything from the channel PR? I'd have expected it to be stand-alone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things, but generally all looks good!
No, I'm just maintaining a stack of branches and I thought the other PR would be approved first. I looks like this one will leapfrog the other so I'll rebase on master. |
80e3f33
to
638b6ee
Compare
stuartmorgan-g
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few more nits.
638b6ee
to
e24f3a3
Compare
e24f3a3
to
8e950ad
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2020
This was referenced May 12, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2020
iskakaushik
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2020
* db82bfb Roll src/third_party/skia c74db7998b4e..518fd4d9d09d (1 commits) (flutter/engine#18278) * 4a1f9fa refactor the task_runner and task_runner_checker (flutter/engine#18238) * ccfec72 Fix grammar in FlBinaryCodec/FlStringCodec descriptions (flutter/engine#18268) * 044f254 Use the term 'handler' for registering callbacks. (flutter/engine#18269) * 8d76518 Fix latest_frame_target_time race (flutter/engine#18279) * 72a48bd Fix incorrect declaration of FlBinaryCodec (flutter/engine#18283) * cb6b620 Roll src/third_party/skia 518fd4d9d09d..dd1de25896e9 (2 commits) (flutter/engine#18282) * b1622c2 Roll src/third_party/dart 4e520824f502..2497606fed87 (11 commits) (flutter/engine#18284) * 2f6bcde Add FlStandardMessageCodec (flutter/engine#18213) * 4aa928d Roll src/fuchsia/sdk/mac from Hss3M... to gOhJW... (flutter/engine#18286) * a549e96 Roll src/fuchsia/sdk/linux from oDp5y... to TZN85... (flutter/engine#18287) * 8b49873 add new keyboard types and missing autofill hints (flutter/engine#18202) * 86462ee Roll src/third_party/dart 2497606fed87..c6db98667aa6 (4 commits) (flutter/engine#18289) * 624480f Roll src/third_party/skia dd1de25896e9..36bda05b2199 (1 commits) (flutter/engine#18291) * ea0a764 Roll src/third_party/skia 36bda05b2199..4e9cfe7691dd (4 commits) (flutter/engine#18292) * 7cf426e Roll src/third_party/dart c6db98667aa6..245a574301b1 (3 commits) (flutter/engine#18294) * 8d379e9 Roll src/third_party/skia 4e9cfe7691dd..3d2c41b773f6 (1 commits) (flutter/engine#18296) * f4220c2 Roll src/third_party/dart 245a574301b1..d5650235a249 (7 commits) (flutter/engine#18297) * 7eb6ffe [fuchsia] Disable failing physical shape layer tests (flutter/engine#18308) * 6689481 Temporarily disabling the fuchsia shell, runtime tests (flutter/engine#18319) * a6baef1 Disable flow tests on Fuchsia (flutter/engine#18323) * f6d3e7f Disable all fuchsia tests temporarily (flutter/engine#18326) * b59e3e9 Roll src/third_party/dart d5650235a249..2bf325900586 (35 commits) (flutter/engine#18327)
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #18189