This repository was archived by the owner on Feb 25, 2025. It is now read-only.
null-annotate lib/ui/hooks.dart #18555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
commented
May 21, 2020
| @@ -269,7 +269,7 @@ void _invoke(void callback(), Zone zone) { | |||
| } | |||
|
|
|||
| /// Invokes [callback] inside the given [zone] passing it [arg]. | |||
| void _invoke1<A>(void callback(A a), Zone zone, A arg) { | |||
| void _invoke1<A>(void callback(A a)/*?*/, Zone/*!*/ zone, A arg) { | |||
There was a problem hiding this comment.
Thoughts on whether we should mark the callback params one way or another? Not entirely sure I trust the migration tool's judgement on the _invoke* calls.
There was a problem hiding this comment.
Good point. I think we should. These are basically anonymous typedefs, and I would definitely annotate a typedef.
yjbanov
approved these changes
May 26, 2020
| @@ -65,11 +65,11 @@ String _localeClosure() { | |||
|
|
|||
| @pragma('vm:entry-point') | |||
| // ignore: unused_element | |||
| _LocaleClosure _getLocaleClosure() => _localeClosure; | |||
| _LocaleClosure/*?*/ _getLocaleClosure() => _localeClosure; | |||
There was a problem hiding this comment.
I think this is safe to be non-null. _localeClosure is just a tear-off of a top-level function.
|
|
||
| @pragma('vm:entry-point') | ||
| // ignore: unused_element | ||
| void _updateLocales(List<String> locales) { | ||
| void _updateLocales(List<String/*!*/>/*!*/ locales) { |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.