This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixes FlutterEngine internal retain cycle #18595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Jun 15, 2020
gaaclarke
reviewed
Jun 15, 2020
gaaclarke
suggested changes
Jun 15, 2020
gaaclarke
reviewed
Jun 16, 2020
| }]; | ||
|
|
||
| auto platformViewsController = _platformViewsController.get(); |
There was a problem hiding this comment.
This one should still use the weakptr trick you were using previously. The reason is that platformViewsController is a C++ object which means it won't get retained when it is captured by the block. In practice this looks like it would be safe today but I think we should err on the side of caution.
gaaclarke
approved these changes
Jun 17, 2020
gaaclarke
force-pushed
the
fix_engine_leaks
branch
from
9be9c9e to
b511285
Compare
|
Landing on red, the CI failure was a flake. It passed when rerun here: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/aaclarke_google.com/a96bf18d97c25854a608cf5e25f0bd8ce76c3a567885d6fcdce4aef30bb56b4b/+/annotations?server=chromium-swarm.appspot.com |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
This was referenced Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.