Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

jason-simmons
Copy link
Member

@jason-simmons jason-simmons requested a review from iskakaushik June 5, 2020 22:51
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@auto-assign auto-assign bot requested a review from cbracken June 5, 2020 22:51
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 9, 2020
@fluttergithubbot fluttergithubbot merged commit e8c13aa into flutter:master Jun 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TraceEventAsyncComplete in fml/trace_event.h and trace_event.cc seems not disabled for release mode
4 participants