This repository was archived by the owner on Feb 25, 2025. It is now read-only.
nullability clean-ups #18880
Merged
nullability clean-ups #18880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The luci-engine redness was on a Skia commit. I will land this and see if it fixes the engine breakage. If it does, then the breakage was a flake. If not, we'll have to revert the Skia roll. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2020
cg021
pushed a commit
to cg021/engine
that referenced
this pull request
Jun 9, 2020
* nullability clean-ups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various code clean-ups for smoother null safety migration:
lerpmethods such that type inference can infer variable nullability (removed all casts and!in the migrated output)_lerpDouble,_lerpInt, and_clampIntthat remove dynamic casts.VerticesandCanvasintodart:_engine. This removes the web-only additions to theVerticesAPI, and removes the need to migrate canvas code as part ofdart:ui.latedue to incompatibility with our initialization code (we use null check to detect if a variable is initialized, which is not supported bylate: Null safety: late non-null variables should not complain about null checking dart-lang/sdk#42214).Related Issues
flutter/flutter#53661