Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add FlMouseCursorPlugin #18888

Merged
merged 6 commits into from
Jun 10, 2020
Merged

Add FlMouseCursorPlugin #18888

merged 6 commits into from
Jun 10, 2020

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Jun 8, 2020 •
edited
Loading

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@auto-assign auto-assign bot requested a review from flar June 8, 2020 04:41
stuartmorgan-g
stuartmorgan-g approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor

Please edit the description to indicate the bug it fixes. I've been forgetting to mention that in previous PRs, but it really helps understand the context of PRs after the fact. And if you say "Fixes " it'll auto-close the issue when you land it.

@stuartmorgan-g
Copy link
Contributor

FYI: #18916

You can update this to include those now if you want, or leave it for a follow-up.

@robert-ancell
Copy link
Contributor Author

FYI: #18916

You can update this to include those now if you want, or leave it for a follow-up.

Since the build is currently broken, now seems like a good time :)

@robert-ancell robert-ancell merged commit 101e854 into flutter:master Jun 10, 2020
@robert-ancell robert-ancell deleted the linux-shell-mouse-cursor branch June 10, 2020 02:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
101e854 Add FlMouseCursorPlugin (flutter/engine#18888)
82fc3e2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
101e854 Add FlMouseCursorPlugin (flutter/engine#18888)
2082fdf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
101e854 Add FlMouseCursorPlugin (flutter/engine#18888)
ae41be1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
101e854 Add FlMouseCursorPlugin (flutter/engine#18888)
195a94e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
101e854 Add FlMouseCursorPlugin (flutter/engine#18888)
ab3edb2
@gspencergoog gspencergoog mentioned this pull request Jun 10, 2020
Open
17 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
101e854 Add FlMouseCursorPlugin (flutter/engine#18888)
749fc37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020
@engine-flutter-autoroll
101e854 Add FlMouseCursorPlugin (flutter/engine#18888)
f83caca
This was referenced Jun 11, 2020
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020
@engine-flutter-autoroll
101e854 Add FlMouseCursorPlugin (flutter/engine#18888)
124e4c2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@flar flar Awaiting requested review from flar

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GTK: Mouse system cursor support
4 participants
@robert-ancell @fluttergithubbot @stuartmorgan-g @googlebot