Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Jun 10, 2020

@auto-assign auto-assign bot requested a review from flar June 10, 2020 04:47
@robert-ancell robert-ancell force-pushed the text-input-rtl-selection branch from f9daadc to e331348 Compare June 10, 2020 04:48
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the mixture of abstract things like "forward" and direction-specific things like "left" and "right" are going to bite us when we add RTL text handling, but since this is internal we can cross that bridge when we get to it (and currently we aren't tracking text direction in the model).

@robert-ancell
Copy link
Contributor Author

I suspect that the mixture of abstract things like "forward" and direction-specific things like "left" and "right" are going to bite us when we add RTL text handling, but since this is internal we can cross that bridge when we get to it (and currently we aren't tracking text direction in the model).

Yeah, I was concerned about that too. I originally had the methods public and then made them private so we can rethink the terminology when that complexity comes later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting TextField with keyboard from right to left not working
3 participants