Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

nturgut
Copy link
Contributor

@nturgut nturgut commented Jun 10, 2020

Renaming variables on integration tests manager for handling blocked tests.

@nturgut nturgut requested a review from ferhatb June 10, 2020 21:21
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@ferhatb ferhatb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this.

@nturgut nturgut added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 10, 2020
@nturgut
Copy link
Contributor Author

nturgut commented Jun 10, 2020

Merging the PR, changes are related to currently broken 'Mac Host Tests'.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants