This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Word substitutions #19111
Merged
Word substitutions #19111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Jun 18, 2020
tools/licenses/lib/main.dart
Outdated
| @@ -2099,10 +2099,10 @@ class _RepositoryFlutterDirectory extends _RepositoryDirectory { | |||
| /// A specialized crawler for "github.com/flutter/engine/lib" directory. | |||
| /// | |||
| /// It includes everything except build tools, test build artifacts, and test code. | |||
| _RelativePathBlacklistRepositoryDirectory _createLibDirectoryRoot(fs.Directory entry, _RepositoryDirectory parent) { | |||
| return _RelativePathBlacklistRepositoryDirectory( | |||
| _RelativePathBlocklistRepositoryDirectory _createLibDirectoryRoot(fs.Directory entry, _RepositoryDirectory parent) { | |||
There was a problem hiding this comment.
IIRC Dart went with "DenyList" do we want to be consistent with their terminology?
goderbauer
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
Looks like the licence tool signature needs to be updated since the tool changed. |
goderbauer
force-pushed
the
word-substitutions
branch
from
2c16bf3 to
d1be0ad
Compare
|
Licenses updated, let's try this again. |
goderbauer
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests
I added the following tests:
Adjusted to new names.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.