This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Add GetBoundingRectAfterMutations to EmbeddedViewParams to calculate the final bounding rect for platform view #19170"
#19212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2020 09:25
…rams to calculate the final bounding rect for platform view (flutter#19170)" (flutter#19204)" This reverts commit 9cecc5f.
cyanglaz
commented
Jun 22, 2020
| params.offsetPixels.y(), // | ||
| params.sizePoints.width() * device_pixel_ratio_, // | ||
| params.sizePoints.height() * device_pixel_ratio_ // | ||
| return SkRect::MakeXYWH(params.finalBoundingRect().x(), // |
There was a problem hiding this comment.
This "reland" fixes the build error here.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
…rams to calculate the final bounding rect for platform view flutter#19170" (flutter/engine#19212)
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Jun 24, 2020
…calculate the final bounding rect for platform view flutter#19170" (flutter#19212)
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reland #19170, it had a compiling error because #19033 was landed a moment before and was using an API that was updated by #19170
I marked the difference between this relanding PR and the original PR