This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Position overlay layer views in PlatformViewsController.onDisplayOverlaySurface #19295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
blasten
reviewed
Jun 25, 2020
| }, | ||
| 1000); | ||
| public void acquireLatestImageViewFrame() { | ||
| flutterImageView.acquireLatestImage(); |
There was a problem hiding this comment.
minor nit: flutterImageView is nullable
blasten
reviewed
Jun 25, 2020
| int key = overlayLayerViews.keyAt(i); | ||
| FlutterImageView overlayView = overlayLayerViews.valueAt(i); | ||
| if (currentFrameUsedOverlayLayerIds.contains(key)) { | ||
| overlayView.acquireLatestImage(); |
There was a problem hiding this comment.
The Android team suggested to acquire the image off the UI thread. This can be done later, just fyi.
There was a problem hiding this comment.
Same for the one above, but I guess that could go in a single PR.
jason-simmons
force-pushed
the
hybrid_display_overlay_surface
branch
from
c70fce4 to
0d9339b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2020
…playOverlaySurface (flutter/engine#19295)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.