This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Cache CanvasKit objects and delete if not used. #19341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a cache of Skia objects and deletes the least recently used ones when the cache fills up. Fixes flutter/flutter#56938
yjbanov
approved these changes
Jun 27, 2020
| } | ||
|
|
||
| /// A [SkiaObject] which is deleted once and cannot be used again. | ||
| class OneShotSkiaObject extends SkiaObject { |
There was a problem hiding this comment.
Why not abstract like ResurrectableSkiaObject?
There was a problem hiding this comment.
Everywhere OneShotSkiaObject is used, it's simply a wrapper around a JsObject, so since there was no special logic for resurrecting the JsObject it didn't need to be subclassed.
|
I made |
yjbanov
approved these changes
Jun 29, 2020
| ui.TextDirection? _textDirection; | ||
| String? _fontFamily; | ||
| SkParagraphStyle _style; | ||
| List<_ParagraphCommand> _commands; |
There was a problem hiding this comment.
Can these fields be final?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds caching for allocated CanvasKit objects and deletes the least recently used ones when the cache is full.
Related Issues
Fixes flutter/flutter#56938
Tests
I added the following tests:
Renamed
test/canvaskit/util_test.darttotest/canvaskit/skia_object_cache_test.dartand added tests for the caching.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.