This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Set child_layer_exists_below flag for Fuchsia PlatformViewLayer #19462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
sanjayc77
commented
Jul 1, 2020
| @@ -31,10 +31,6 @@ void PlatformViewLayer::Preroll(PrerollContext* context, | |||
| context->mutators_stack); | |||
| context->view_embedder->PrerollCompositeEmbeddedView(view_id_, | |||
| std::move(params)); | |||
| #if defined(LEGACY_FUCHSIA_EMBEDDER) | |||
There was a problem hiding this comment.
Removed this block, set_needs_system_composite is set by CheckForChildLayerBelow
|
Looking at the broken unittest: PlatformViewLayerTest.NullViewEmbedderDoesntPrerollCompositeOrPaint |
This enables proper compositing of surfaces with elevation over a PlatformViewLayer.
arbreng
approved these changes
Jul 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables proper compositing of surfaces with elevation over
a PlatformViewLayer.