Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fuchsia: Allow setting thread-name #19792

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

arbreng
Copy link
Contributor

@arbreng arbreng commented Jul 16, 2020

This aids debugging a lot, and the log currently has errors about failing to set the names for various threads

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@auto-assign auto-assign bot requested a review from flar July 16, 2020 00:43
@arbreng arbreng requested a review from freiling July 16, 2020 01:11
@gw280
Copy link
Contributor

gw280 commented Jul 16, 2020

Oh right, we used to have this but it got backed out because of the big threading issues we had using zx loops :(

@arbreng arbreng merged commit bf9d2ea into flutter:master Jul 16, 2020
@arbreng arbreng deleted the fuchsia-threadname branch July 16, 2020 19:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants