Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove android view from the Mutator stack #19972

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

blasten
Copy link

@blasten blasten commented Jul 23, 2020

Description

The view should be removed from the mutator stack view since the Android view system doesn't allow to add a view to a ViewGroup if it's already in a parent ViewGroup.

Related Issues

Fixes flutter/flutter#62079

Tests

I added the following tests: 3 unit tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blasten blasten merged commit 88ebc37 into flutter:master Jul 23, 2020
@blasten blasten deleted the fix_view_cache_bug branch July 23, 2020 17:50
pcsosinski pushed a commit to pcsosinski/engine that referenced this pull request Jul 23, 2020
pcsosinski pushed a commit that referenced this pull request Jul 27, 2020
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a view is cached in PlatformViewFactory#create then an exception occurrs
3 participants