Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

MichealReed
Copy link
Contributor

Description

Network image did not work when using CanvasKit, this uses an http request to retrieve the image from the given uri and provides it to skia. Since this does not use an img tag, proper CORS handling will be required.

Related Issues

Fixes flutter/flutter#49725 and flutter/flutter#55476

Tests

Covered by existing tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [contributor guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [C++, Objective-C, Java style guides] for the engine.
  • I read the [tree hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Aug 2, 2020

This definitely needs tests.

@yjbanov yjbanov added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 4, 2020
@MOPineyro
Copy link

@MichealReed thanks for this PR, was hoping it would solve the issues, but still getting failures trying to load pngs with Network Image, any advice?

@yjbanov
Copy link
Contributor

yjbanov commented Sep 25, 2020

@MOPineyro please file a new issue so we can discuss it at the issue triage. It is also possible that you are hitting the CORS problem (flutter/flutter#45955), which is on our roadmap to address.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] [CanvasKit] Image.network does not display the image
6 participants