This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Implement support for WidgetSpan (aka paragraph placeholders) #20276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2020
ferhatb
approved these changes
Aug 6, 2020
yjbanov
reviewed
Aug 6, 2020
yjbanov
approved these changes
Aug 6, 2020
This was referenced Aug 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2020
daohoangson
added a commit
to daohoangson/flutter_widget_from_html
that referenced
this pull request
Aug 19, 2020
Thanks to flutter/engine#20276 being merged recently. Use Flutter `master` channel to deploy web app for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
WidgetSpanin flutter web.Related Issues
Fixes flutter/flutter#42086
Fixes flutter/flutter#62749
Tests
I added the following tests:
test/golden_tests/engine/text_placeholders_test.dart(goldens)