This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Create scenic session with view focuser #20288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
approved these changes
Aug 7, 2020
This change creates the scenic session with request to Focuser. The focuser is used to request focus to a view, given it's ViewRef. The call to requestFocus is made from PlatformView messages channel, which will be used from Flutter side by ChildView. Adds a PlatformView unittest for the requestFocus method.
|
Failing check was an infra failure, so merging |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change creates the scenic session with request to Focuser. The focuser is used to request focus to a view, given it's ViewRef. The call to requestFocus is made from PlatformView messages channel, which will be used from Flutter side by ChildView.
Tests
Adds a PlatformView unittest for the requestFocus method.