This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add script to compile JIT on x86 #20315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
approved these changes
Aug 7, 2020
| @@ -42,6 +42,18 @@ compared against golden reside. | |||
|
|
|||
| ## Running for Android | |||
|
|
|||
| The test is run on a x86 emulator. To run the test locally, you must create an emulator running API level 28, and set the following screen settings in the avd's `config.ini` file: | |||
There was a problem hiding this comment.
I think there is an ongoing effort to move to api level 29 do we want to update this to 29?
There was a problem hiding this comment.
This sounds doable. I can coordinate that the Chrome infra folks.
| @@ -0,0 +1,64 @@ | |||
| #!/bin/bash | |||
| # Copyright 2013 The Flutter Authors. All rights reserved. | |||
There was a problem hiding this comment.
I think the license banner consistently uses 2013. https://github.com/flutter/engine/search?p=5&q=Copyright+2013&unscoped_q=Copyright+2013
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
build_and_run_android_tests.shwill be called from the LUCI recipe. The scenario will run on an x86 emulator, so JIT is required.Related Issues
flutter/flutter#55326
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.