Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Prepare scenario app to run on Android emulator on LUCI #20350

Merged
merged 9 commits into from
Aug 11, 2020
Merged

Prepare scenario app to run on Android emulator on LUCI #20350

merged 9 commits into from
Aug 11, 2020

Conversation

blasten
Copy link

@blasten blasten commented Aug 8, 2020 •
edited
Loading

Changes the scenario app, so they can run on LUCI/Android emulator.

  1. Use bash instead of sh to prevent:
 /b/s/w/ir/cache/builder/src/flutter/testing/scenario_app/build_and_run_android_tests.sh: 14: /b/s/w/ir/cache/builder/src/flutter/testing/scenario_app/build_and_run_android_tests.sh: Bad substitution
 /b/s/w/ir/cache/builder/src/flutter/testing/scenario_app/build_and_run_android_tests.sh: 16: /b/s/w/ir/cache/builder/src/flutter/testing/scenario_app/build_and_run_android_tests.sh: pushd: not foun

  1. Fix a race condition caused by waiting on vsync

  2. Fix virtual display screenshots

cc @dnfield since these are new changes.

@blasten blasten requested a review from godofredoc August 8, 2020 00:33
@auto-assign auto-assign bot requested a review from GaryQian August 8, 2020 00:35
@blasten blasten changed the title Remove pushd and popd from script Use bash scripting instead of shell Aug 8, 2020
@blasten blasten changed the title Use bash scripting instead of shell Prepare scenario app to run on Android emulator on LUCI Aug 11, 2020
@flutter flutter deleted a comment from flutter-dashboard bot Aug 11, 2020
@blasten blasten requested a review from dnfield August 11, 2020 04:39
@flutter flutter deleted a comment from flutter-dashboard bot Aug 11, 2020
@blasten blasten merged commit 8c02e38 into flutter:master Aug 11, 2020
@blasten blasten deleted the remove_pushd branch August 11, 2020 05:55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 11, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 11, 2020
@engine-flutter-autoroll
8c02e38 Prepare scenario app to run on Android emulator on LUCI (flut…
0c6ce77 
…ter/engine#20350)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryQian GaryQian Awaiting requested review from GaryQian

@dnfield dnfield Awaiting requested review from dnfield

1 more reviewer

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blasten @godofredoc @googlebot