This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Release the AccessibilityBridge when destroying a legacy FlutterView #20610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy io.flutter.view.FlutterView class was releasing the AccessibilityBridge in its override of View.onDetachedFromWindow. However, onDetachedFromWindow is called after the activity onDestroy lifecycle event which typically calls FlutterView.destroy. If the AccessibilityBridge listener is invoked after FlutterView.destroy, then its calls to Flutter engine JNI APIs will fail. This change will release the AccessibilityBridge and remove the listener before FlutterView.destroy detaches from the engine. Fixes flutter/flutter#63555
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Also see discussions of this in flutter/flutter#33511 and #17292 (comment) |
|
I was gonna ask you for tests but then thought it'd be ok to exempt files we're about to delete soon™️ LGTM |
jason-simmons
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
xster
approved these changes
Aug 19, 2020
xster
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2020
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Aug 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy io.flutter.view.FlutterView class was releasing the
AccessibilityBridge in its override of View.onDetachedFromWindow.
However, onDetachedFromWindow is called after the activity onDestroy
lifecycle event which typically calls FlutterView.destroy. If the
AccessibilityBridge listener is invoked after FlutterView.destroy, then
its calls to Flutter engine JNI APIs will fail.
This change will release the AccessibilityBridge and remove the listener
before FlutterView.destroy detaches from the engine.
Fixes flutter/flutter#63555