[embedder] Add gl present callback that takes present info #20672
Conversation
|
I am looking for ideas to effectively test that the right fbo is given back to present. My current thought is to make Are there any better ways of doing this than to wire up the test gl surface to do the double buffering? cc: @chinmaygarde , @stuartmorgan |
iskakaushik
force-pushed
the
eb-2
branch
2 times, most recently
from
4b1be0e to
7389195
Compare
There was a problem hiding this comment.
This looks reasonable to me, but this layer is not at all my area of expertise; @chinmaygarde should definitely sign off on it (and would be much better equipped than me to advise on testing strategies for the embedder API).
When we present a frame we now pass back the fbo information to the embedder. While this is usually the window fbo, this could be different and now the embedder will have a chance to release the fbo or do any additional book-keeping that it wishes to do. To this effect, we have added a `present_with_info` callback, which is a variant of the `present` callback that has `FlutterPresentInfo` passed to it.
| @@ -121,6 +136,8 @@ class EmbedderTestContext { | |||
| size_t software_surface_present_count_ = 0; | |||
| std::mutex gl_get_fbo_callback_mutex_; | |||
| GLGetFBOCallback gl_get_fbo_callback_; | |||
| std::mutex gl_present_callback_mutex_; | |||
There was a problem hiding this comment.
I suppose you could use a common mutex for these callbacks now.
|
|
||
| context.SetGLPresentCallback([&frame_latch](uint32_t fbo_id) { | ||
| // this must be the window FBO id. | ||
| ASSERT_EQ(fbo_id, 0u); |
There was a problem hiding this comment.
IMO, the test would be more resilient to changes in the context used by the fixture if it didn't assume FBO 0 was the onscreen FBO. It happens to the case in the test context. How about an accessor on the test context that returns the FBO ID upfront. You can use that in your assertion here.
This is a minor nit but worth considering.
iskakaushik
added
the
waiting for tree to go green
When we present a frame we now pass back the fbo information to the embedder. While this is usually the window fbo, this could be different and now the embedder will have a chance to release the fbo or do any additional book-keeping that it wishes to do.
To this effect, we have added a
present_with_infocallback, which is a variant of thepresentcallback that hasFlutterPresentInfopassed to it.See EC-2 in flutter.dev/go/double-buffered-window-resize and flutter/flutter#44136