Add tests for lerpDouble #20778
Add tests for lerpDouble #20778
Conversation
The behaviour of lerpDouble with respect to null inputs isn't entirely obvious. In the case where both inputs are null, it returns null. Otherwise, it defaults the null parameter to 0.0 and carries on. Post non-null by default, it might be nice to strengthen the parameter contract to require them to be non-null. While this would be a breaking change, it seems likely that the framework either meets this guarantee or can provide it without a framework breaking change. flutter/flutter#64617 tracks the above. In the meantime, adding a test to lock in the current behaviour.
|
/cc @matthew-carroll as this relates to #20775. /cc @yjbanov for thoughts on NNBD-related change. Discussion in flutter/flutter#64617. |
|
Our documentation on running the Dart tests could definitely be better. The general command for running all the tests from the To run just the Dart tests, you can run the following command (which is one of the commands in the above script): |
|
@cbracken please add that to the wiki! |
| expect(lerpDouble(0.0, 10.0, 5.0), 50.0); | ||
| expect(lerpDouble(10.0, 0.0, 5.0), -40.0); | ||
| }); | ||
| } |
There was a problem hiding this comment.
we could also test infinities, NaNs, very large numbers, very small numbers...
There was a problem hiding this comment.
Good call. I'll land this as-is for the moment and make the wiki updates so that @matthew-carroll is unblocked on his work, but will add those in a followup PR.
Actually, turns out we did add it to the wiki at some point. Thanks @xster! This definitely used to be very under-documented, but the docs there are looking pretty comprehensive now. https://github.com/flutter/flutter/wiki/Testing-the-engine#dart---dartui |
|
😲 @cbracken and @matthew-carroll join forces? Avengers assemble! 🦸♂️ |
|
|
* b08c6b9 Fixing synthesizing keys for multiple keys pressed down on flutter web (flutter/engine#19632) * 8308b6a Avoid passing nil to IOS accessibility announcement (flutter/engine#20700) * 950b6a0 Roll Skia from ead4ca052b99 to 5da7327358e3 (1 revision) (flutter/engine#20782) * 87fd0e4 Guard recording_canvas against restore calls without ending recording (flutter/engine#20786) * 388193a Add tests for lerpDouble (flutter/engine#20778)
* b08c6b9 Fixing synthesizing keys for multiple keys pressed down on flutter web (flutter/engine#19632) * 8308b6a Avoid passing nil to IOS accessibility announcement (flutter/engine#20700) * 950b6a0 Roll Skia from ead4ca052b99 to 5da7327358e3 (1 revision) (flutter/engine#20782) * 87fd0e4 Guard recording_canvas against restore calls without ending recording (flutter/engine#20786) * 388193a Add tests for lerpDouble (flutter/engine#20778)
* b08c6b9 Fixing synthesizing keys for multiple keys pressed down on flutter web (flutter/engine#19632) * 8308b6a Avoid passing nil to IOS accessibility announcement (flutter/engine#20700) * 950b6a0 Roll Skia from ead4ca052b99 to 5da7327358e3 (1 revision) (flutter/engine#20782) * 87fd0e4 Guard recording_canvas against restore calls without ending recording (flutter/engine#20786) * 388193a Add tests for lerpDouble (flutter/engine#20778)
Description
Add tests for
lerpDouble.The behaviour of
lerpDoublewith respect to null inputs isn't entirely obvious. In the case where both inputs are null, it returns null. Otherwise, it defaults the null parameter to 0.0 and carries on.Post non-null by default, it might be nice to strengthen the parameter contract to require them to be non-null. While this would be a breaking change, it seems likely that the framework either meets this guarantee or can provide it without a framework breaking change.
Related Issues
flutter/flutter#64617 tracks making the parameters non-nullable.
Tests
This adds Dart unittests for
lerpDouble.