Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[iOS TextInput] Avoid Unnecessary UndateEditingClient Calls #21303

Merged
merged 2 commits into from
Sep 21, 2020
Merged

[iOS TextInput] Avoid Unnecessary UndateEditingClient Calls #21303

merged 2 commits into from
Sep 21, 2020

Conversation

LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Sep 21, 2020 •
edited
Loading

Description

flutter/flutter#66144 (comment). I'm working on removing the "updateEditingState" call triggered by textDidChange.

Related Issues

Fixes flutter/flutter#66144

Tests

I added the following tests:

  • testUITextInputAvoidUnnecessaryUndateEditingClientCalls

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review September 21, 2020 21:27
@auto-assign auto-assign bot requested a review from GaryQian September 21, 2020 21:27
justinmc
justinmc approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as this doesn't break any tests.

Why were we deliberately sending updates for composing text and selection if it wasn't necessary? Did something change to make it unnecessary?

@LongCatIsLooong
Copy link
Contributor Author

@justinmc I thought that was the case too but it turns out we shouldn't do that at all: #3995. It was a workaround to trigger EditableText.onChanged call for TextEditingValue changes made via the text selection menu.

@LongCatIsLooong LongCatIsLooong added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 21, 2020
@fluttergithubbot fluttergithubbot merged commit 3f27800 into flutter:master Sep 21, 2020
@LongCatIsLooong LongCatIsLooong deleted the ios-textinput-avoid-acking branch September 21, 2020 22:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
60714bf 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
a852764 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
6022b69 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
4456165 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
eb6cc76 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
5ac2035 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
6dbeaff 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
e6d58b2 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
485ed9b 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
680b96e 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
bf54c9c 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
b58925b 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
83f1d39 
…lutter/engine#21303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
3f27800 [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (f…
8cdcdea 
…lutter/engine#21303)
@britannio britannio mentioned this pull request Oct 28, 2020
Closed
@LongCatIsLooong LongCatIsLooong mentioned this pull request Nov 2, 2020
Closed
christopherfujino added a commit that referenced this pull request Nov 12, 2020
@christopherfujino @LongCatIsLooong @gaaclarke
[flutter_releases] Flutter 1.22.4 engine cherrypicks (#22449)
bba39d2 
* Update 1.22 engine to use Dart 2.10.4
* [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (#21303)
* added unit tests to the rasterizer (#22282)
* Reland "Do not involve external_view_embedder in submit frame process if threads are not merged. #22275" (#22372)

Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
Co-authored-by: Chris Yang <ychris@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

@GaryQian GaryQian Awaiting requested review from GaryQian

1 more reviewer

@justinmc justinmc justinmc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] adding autoFillHint to TextFormField breaks FocusScope.of(context).nextFocus()
4 participants
@LongCatIsLooong @justinmc @googlebot @fluttergithubbot