Split AOT Android Embedder and shell #22179

GaryQian · 2020-10-28T23:57:57Z

Description

go/flutter-aot-split
go/flutter-split-aot-instructions

For flutter/flutter#57617 and flutter/flutter#62229

This PR contains android embedder and engine shell implementations of Split AOT that handles downloading the dynamic feature module, and passing the necessary data to the runtime in order to load a dart shared library.

In the android embedder, we add DynamicFeatureManager, which provides the general API for downloading dynamic features. The flutter play store default implementation is PlayStoreDynamicFeatureManager, which interfaces with the play store to download the APK as well as load assets and load the split dart library. Third party custom implementations of DynamicFeatureManager may be provided to FlutterJNI or the FlutterEngine java class to enable custom download and load behavior.

The shell code passes down the request to download a library via PlatformView to the embedder, as well as passes the APK paths up to the runtime controller to find the lib and load it.

The boundary of this PR is engine.cc/h, where the code that connects it to the runtime implementation (in a future PR, preliminary version can be viewed at #21173) resides. I will be landing the runtime portion of this feature after more work is done on it.

The API in this PR is not meant to be permanent, but rather a concrete working step towards fully functional split AOT apps as it gets landed/developed over next few weeks.

The WIP tooling that generates the AAB bundles can be found at flutter/flutter#63773

Tests

Tests for PlayStoreDynamicFeatureManager and FlutterInjector. Shell tests need full shell implementation before they can work.

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

shell/common/platform_view.h

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

jason-simmons · 2020-10-29T19:22:06Z

shell/platform/android/platform_view_android_jni_impl.cc

+                               jobject jAssetManager,
+                               jstring jAssetBundlePath) {
+  auto asset_manager = std::make_shared<flutter::AssetManager>();
+  asset_manager->PushBack(std::make_unique<flutter::APKAssetProvider>(


Not sure if this is an issue, but this will potentially lose any other asset resolvers that were in the old asset manager (such as directories holding assets that were pushed during a hot reload)

Will look into this!

shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java

shell/platform/android/platform_view_android_jni_impl.cc

shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java

jason-simmons · 2020-10-29T20:50:42Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+
+  public void loadAssets(@NonNull String moduleName, int loadingUnitId) {
+    try {
+      context = context.createPackageContext(context.getPackageName(), 0);


Is this intentionally overwriting the context that was passed into the constructor?

Yes. This context overwrite ensures that the newly installed dynamic feature module is present in the context when we ask for a new asset manager.

xster · 2020-10-30T05:52:32Z

DEPS

@@ -469,7 +469,7 @@ deps = {
     'packages': [
       {
        'package': 'flutter/android/embedding_bundle',
-        'version': 'last_updated:2020-05-20T01:36:16-0700'


I think this is all fine for a local build but you still need to update

engine/shell/platform/android/BUILD.gn

Line 394 in 6166712

script = "//flutter/tools/androidx/generate_pom_file.py"

to actually build it into the distributed engine artifact.

i.e. I don't think this will compile on LUCI. @jason-simmons might know more.

The LUCI tests were able to all pass on this PR this afternoon, I'll take a look at updating it in the above mentioned spot too.

I think it'll pass on LUCI since the tests will run in the "development path". But I think it won't package up the dependencies in the vendored engine build on cloud storage.

xster · 2020-10-30T05:53:39Z

shell/common/engine.cc

+
+// // |RuntimeDelegate|
+// Dart_Handle Engine::OnDartLoadLibrary(intptr_t loading_unit_id) {
+//   return delegate_.OnDartLoadLibrary(loading_unit_id);


(I'm just reading in order so comments might not be relevant as I read the rest of the files)
Don't know what delegate is. Just a reminder to make sure this is designed generically such that it can fit through the embedder.h API in the future for other platforms.

xster · 2020-10-30T05:55:42Z

shell/common/engine.h

+    /// @return     A Dart_Handle that is Dart_Null on success, and a dart error
+    ///             on failure.
+    ///
+    virtual Dart_Handle OnDartLoadLibrary(intptr_t loading_unit_id) = 0;


Is this the right abstraction to expect the embedder/embeddings to construct a Dart_Handle instance? What would you envision them to fill it with? Does it need an indirection/wrapping that's more accessible to the embedder/embeddings?

I'll just abstract away/handle the dart_handles. This is left over from when I was doing more with the results in experiments.

xster · 2020-10-30T06:00:25Z

shell/common/engine.h

+    ///             be loaded. Notifies the engine that the requested loading
+    ///             unit should be downloaded and loaded.
+    ///
+    /// @param[in]  loading_unit_id  The unique id of the deferred library's


We should clarify at this level what are we loading specifically? Is it the Dart specific loading units or is it the platform-specific bundles? We should be exact with the name. i.e. in the asset-only bundle case, that asset's still loaded through the Dart API or is it a different API?

I will be adding separate dart API for loading by android module name. This is currently strictly for the dart loadLibrary() code path. I'll link to additional info in a separate PR introducing the new API for module name/asset only loading.

shell/common/engine.h

xster · 2020-10-30T06:55:06Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+        // Called when the install request is sent successfully. This is different than a successful
+        // install which is handled in FeatureInstallStateUpdatedListener.
+        .addOnSuccessListener(
+            sessionId -> {


@jason-simmons you sure we should start allowing java 8 usages in our engine? We'd be forcing our users to upgrade if they were still on java 7?

The engine embedder code is already using Java lambdas, and the engine build scripts link to an Android lambda support library

Oh interesting. You're saying there are ways to support this without java 8?

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

xster · 2020-10-30T06:58:08Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+
+  public void loadDartLibrary(String moduleName, int loadingUnitId) {
+    // This matches/depends on dart's loading unit naming convention, which we use unchanged.
+    String aotSharedLibraryName = "app.so-" + loadingUnitId + ".part.so";


I don't know if we can hardcode this name. We probably want to fix flutter/flutter#42214 at some point. I think there are other dupes but I can't find them. Also is this name right for google3?

I believe the "app" in this name is not in reference to the android dir "app" module. It is the default .so name outputted by gen_snapshot. @rmacnak-google can you confirm?

In any case, I can come up with any naming scheme, this will likely change in the future as the tooling becomes more complete.

xster · 2020-10-30T06:58:31Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+    // Possible values: armeabi, armeabi-v7a, arm64-v8a, x86, x86_64, mips, mips64
+    String abi;
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+      abi = Build.SUPPORTED_ABIS[0];


This is apparently the recommended way to obtain the ABI in lollipop+. The other way was deprecated in favor of this.

xster · 2020-10-30T06:59:37Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+    flutterJNI.loadDartLibrary(
+        loadingUnitId,
+        aotSharedLibraryName,
+        apkPaths.toArray(new String[apkPaths.size()]),


whatever's reading specific files out of the APK, we should do it here in this file or at least somewhere in java since it's android specific.

(will move to android-engine, see above comments)

xster · 2020-11-03T02:25:17Z

Tagging flutter/flutter#57617

xster · 2020-11-06T05:54:00Z

Let me know when you're ready for another round.

GaryQian · 2020-11-06T07:50:25Z

Yep, working on getting the asset manager to persist the other asset resolvers instead of overwriting it. Will let you know when ready

GaryQian · 2020-11-07T03:10:38Z

cc @xster should be ready for another round!

xster

Sorry, reviewed halfway. Will finish the rest tonight. There's also still some leftover comments from last time it seems.

xster · 2020-11-09T21:40:11Z

DEPS

@@ -469,7 +469,7 @@ deps = {
     'packages': [
       {
        'package': 'flutter/android/embedding_bundle',
-        'version': 'last_updated:2020-05-20T01:36:16-0700'


I think it'll pass on LUCI since the tests will run in the "development path". But I think it won't package up the dependencies in the vendored engine build on cloud storage.

xster · 2020-11-09T21:42:34Z

shell/common/engine.h

@@ -767,6 +777,27 @@ class Engine final : public RuntimeDelegate,
  ///
  const std::string& InitialRoute() const { return initial_route_; }

+  //--------------------------------------------------------------------------
+  /// @brief      Loads the dart shared library into the dart VM. When the


Is the verb right? Does the implementation of this function execute the act of "loading" or does it just signal that it can be consumed now?

I guess it depends on what you would consider "loading". If you consider dlopen-ing a file and resolving symbols loading, then indeed it just passes the results of that on. On the other hand, this method does directly call Dart_DeferredLoadComplete, which "loads" the symbols into the running isolate. In this case, this method does invoke loading with the provided symbols.

ya, I just realized my understanding was incorrect. I think in your diagram, there's actually another bubble somewhere in the Runtime/VM box that's for "consuming the bytes than represent the AOT program" like how you have a small bubble for dlopen etc.

In that case, maybe this function should just be called loadDartDeferredLibrary too since the implementation behind this function (the vm) loads the program given to it.

xster · 2020-11-09T21:43:32Z

shell/common/engine.h

+  /// @brief      Loads the dart shared library into the dart VM. When the
+  ///             dart library is loaded successfully, the dart future
+  ///             returned by the originating loadLibrary() call completes.
+  ///             Each shared library is a loading unit, which consists of


I didn't understand what this sentence meant to communicate :) It describes the what but the why might be missing

xster · 2020-11-09T21:44:05Z

shell/common/engine.h

+  ///             deferred libraries that can be compiled split from the
+  ///             base dart library by gen_snapshot.
+  ///
+  /// @param[in]  loading_unit_id  The unique id of the deferred library's


Explicitly state this loading unit id's relationship with the previous request call? Or are they independent?

You didn't address this one. The 2 functions' docs should explicitly cross-reference each other.

shell/common/platform_view.h

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

xster · 2020-11-09T22:50:24Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+   * loadingUnitId or moduleName must be valid or non-null.
+   *
+   * @param loadingUnitId The unique identifier associated with a dart deferred library. This id is
+   *                      assigned by gen_snapshot and can be referenced via bundle_config.yaml.


reference the front facing flutter build rather than gen_snapshot.

xster · 2020-11-09T22:51:07Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+   *                      Passing a loadingUnitId larger than the highest valid loading unit's id will
+   *                      cause the dart loadLibrary() to complete with a failure.
+   *
+   * @param moduleName    The dynamic feature module name as defined in bundle_config.yaml. Flutter's


Be a bit more explicit in terms of who would call these variants specifically in what combination. i.e. the dart side API loadLibrary leads to a call with a loadingUnitId value based on what output file from gen_snapshot? We currently expect the Java application itself (or through a plugin) to call the variant with moduleName. Who calls with both parameters filled?

xster · 2020-11-09T22:51:51Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+   *                      cause the dart loadLibrary() to complete with a failure.
+   *
+   * @param moduleName    The dynamic feature module name as defined in bundle_config.yaml. Flutter's
+   *                      default dynamic feature system stores a mapping of loadingUnitId -> moduleName


Not sure what the subclasser should do with this sentence. What are we instructing the implementer to do?

xster · 2020-11-10T05:34:04Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+  /**
+   * Extract and load any assets and resources from the module for use by Flutter.
+   *
+   * <p>Assets shoud be loaded before the dart derferred library is loaded, as successful loading of


xster · 2020-11-10T05:35:13Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+   * however, the two parameters are still present for custom implementations that store assets
+   * outside of Android's native system.
+   *
+   * @param loadingUnitId The unique identifier associated with a dart deferred library.


add another paragraph to describe who should call this

xster · 2020-11-10T05:38:51Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+   * <p>Assets shoud be loaded before the dart derferred library is loaded, as successful loading of
+   * the dart loading unit indicates the dynamic feature is fully loaded.
+   *
+   * <p>Depending on the structure of the feature module, there may or may not be assets to extract.


Up until this point, it's a bit vague in terms of what the implementer's minimum responsibility should be. i.e. what new assumptions does the engine make after you call loadDartDeferredLibrary through JNI again? Seems like it's just updateAssetManager. If so, make it explicit.

xster · 2020-11-10T05:41:08Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+   * modules do not have an associated loadingUnitId. Instead, an invalid ID like -1 may be passed to
+   * download only with moduleName. On the other hand, it can be possible to resolve the moduleName based
+   * on the loadingUnitId. This resolution is done if moduleName is null. At least one of
+   * loadingUnitId or moduleName must be valid or non-null.


it's not very clear what the developer implementer should do

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

xster · 2020-11-10T05:55:26Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+  }
+
+  private String loadingUnitIdToModuleName(int loadingUnitId) {
+    // Loading unit id to module name mapping stored in android Strings


is it? How does that happen? :)

It is stored by the tooling in the build process. This may change if/when I come up with a better way to accomplish this.

xster · 2020-11-10T05:56:49Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+            exception -> {
+              switch (((SplitInstallException) exception).getErrorCode()) {
+                case SplitInstallErrorCode.NETWORK_ERROR:
+                  flutterJNI.dynamicFeatureInstallFailure(


does this overlap with the SplitInstallStateUpdatedListener callback above? i.e. could dynamicFeatureInstallFailure happen twice per request?

No, these errors indicate the install request was never registered/started. The errors above indicate a properly fired request has failed.

xster · 2020-11-10T06:00:11Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+  }
+
+  public void uninstallFeature(int loadingUnitId, String moduleName) {
+    // TODO(garyq): support uninstalling.


if you're not supporting it, let's not add it to the interface yet?

I just wanted to clarify that the TODOs I'm adding in this PR are meant to be actually implemented shortly. They usually indicate critical components of the feature that may just be a bit too big or out of scope for a single PR, and will be landed before the feature is considered ready.

xster · 2020-11-10T06:05:56Z

shell/platform/android/platform_view_android_jni_impl.cc

+    handle = ::dlopen(path.c_str(), RTLD_NOW);
+    search_paths.pop_back();
+    if (handle == nullptr) {
+      FML_LOG(ERROR) << "No dart shared library found at \"" << path


are we expecting failures for the first entries of the searchpaths? i.e. is this spammy?

We do expect some failures, I'll remove this log.

xster · 2020-11-10T06:07:02Z

shell/platform/android/platform_view_android_jni_impl.cc

+
+  // Resolve symbols.
+  uint8_t* isolate_data =
+      static_cast<uint8_t*>(::dlsym(handle, DartSnapshot::kIsolateDataSymbol));


if we're going through all the effort of recreating this, it's then not clear why aren't we just using the fml library to start with?

I currently still want explicit control over this process as there are minor nuances that are done differently, I expect to refactor this to use existing FML once the process is more locked down.

xster · 2020-11-10T06:08:22Z

I think all my comments are minor. Generally LGTM. I think this PR's ready for tests

Fit x tests

Implement injector

xster

LGTM! Woohoo!

xster · 2020-11-19T17:27:09Z

shell/platform/android/io/flutter/FlutterInjector.java

@@ -5,7 +5,9 @@
 package io.flutter;

 import android.support.annotation.NonNull;
+import android.support.annotation.Nullable;


Sorry I made a mistake here. If you sync to head, these should be androidx dependencies. The new one should be androidx too.

xster · 2020-11-19T19:23:57Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+  }
+
+  public void destroy() {
+    splitInstallManager.unregisterListener(listener);


while you're here, might as well remove the JNI reference. i.e. during the destruction sequence, there is no guarantee that there won't be a race where a load asset platform channel call lands right as some items are being destroyed.

You didn't address this one.

xster · 2020-11-19T19:24:33Z

shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java

@@ -374,6 +376,7 @@ public void destroy() {
    platformViewsController.onDetachedFromJNI();
    dartExecutor.onDetachedFromJNI();
    flutterJNI.removeEngineLifecycleListener(engineLifecycleListener);
+    flutterJNI.setDynamicFeatureManager(null);
    flutterJNI.detachFromNativeAndReleaseResources();


if FlutterInjector.instance().dynamicFeatureManager() is not null, call destroy

You didn't address this one. I think nothing's calling DynamicFeatureManager.destroy

Github UI didn't register this one changing as well, see lines below.

xster · 2020-11-19T19:27:51Z

shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java

+  public void requestDartDeferredLibrary(int loadingUnitId) {
+    if (dynamicFeatureManager != null) {
+      dynamicFeatureManager.downloadDynamicFeature(loadingUnitId, null);
+    }


Since this is where the rubber meets the road, let's show a scary message here so it's easier to debug. i.e. you used a split aot feature by calling the dart loadLibrary function but didn't set a manager. Please see integration doc: .... Split AOT will not work unless you complete integration from native side.

You didn't address this one

I did, the Github UI just didn't register it as outdated since the comment is on a } :)

xster · 2020-11-19T19:29:16Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+ * loading Dart deferred libraries. A typical code-flow begins with a Dart call to loadLibrary() on
+ * deferred imported library. See https://dart.dev/guides/language/language-tour#deferred-loading
+ * This call retrieves a unique identifier called the loading unit id, which is assigned by
+ * gen_snapshot during compilation. The loading unit id is passed down through the engine and


add a line to say where the user should look to find that id

xster · 2020-11-19T19:34:19Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+ * <p>Flutter dynamic feature support is still in early developer preview and should not be used in
+ * production apps yet.
+ *
+ * <p>The Flutter default implementation is PlayStoreDynamicFeatureManager.


nit (mainly for this class because it's our "main" java doc): use {@link ...} everywhere in this file when referring to other java classes. Use full qualifiers to avoid class imports if needed. Use {@code ...} to refer to non-java code.

{@link #method...} can reference class methods

Yeah, I'll go ahead and go through and add all the links.

xster · 2020-11-19T19:43:46Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+   * is fully initialized, this method should be called to provide the FlutterJNI instance to use
+   * for use in loadDartLibrary and loadAssets.
+   */
+  public abstract void setJNI(FlutterJNI flutterJNI);


yak creep / optional: one way you can get around this is letting the FlutterJNI be in the injector too. Then you can just read from the injector right before use.

xster · 2020-11-19T19:46:42Z

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/DynamicFeatureManager.java

+   */
+  public abstract void uninstallFeature(int loadingUnitId, String moduleName);
+
+  /** Destructor that cleans up any leftover objects that are no longer needed. */


nit on technical wording: Java doesn't have destructors (something that immediately prompts for memory to be release) since it's garbage collected. The best we can say is calling this releases all its resources. After calling this, this object is no longer usable.

xster · 2020-11-19T19:48:31Z

...form/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

+
+  private boolean verifyJNI() {
+    if (flutterJNI == null) {
+      Log.e(TAG, "No FlutterJNI provided.");


I think this appears without context. Be a bit more detailed. You must set this to integrate split modules before calling dart apis or loading assets via platform channel.

This reverts commit 53fc019.

* 53fc019 Split AOT Android Embedder and shell (flutter/engine#22179) * fc55814 Implement Scene.toImage() in CanvasKit mode. (flutter/engine#22085) * c45e02a Roll Dart SDK from 12fded61a2bc to a06d469024fd (1 revision) (flutter/engine#22623) * 550c750 Remove opt outs for dart:ui (flutter/engine#22603) * f2803ac [fuchsia] shader warmup fixes (flutter/engine#22439) * ce94c4e Roll Dart SDK from a06d469024fd to b8fea79a2549 (1 revision) (flutter/engine#22630) * 76b6acb Roll Fuchsia Linux SDK from aAb3NJv_h... to X1ue-JZsc... (flutter/engine#22631) * 976e887 Roll Skia from ed289e777cfa to 9dce4d081f8a (3 revisions) (flutter/engine#22632) * 885bd65 Roll Fuchsia Mac SDK from DQpWjEN59... to wGZWtwuY4... (flutter/engine#22633) * 8971b82 Roll Dart SDK from b8fea79a2549 to 861ebcb175b6 (1 revision) (flutter/engine#22634) * a09cdfd Roll Skia from 9dce4d081f8a to 8c5889937172 (1 revision) (flutter/engine#22635) * a9f332c Roll Dart SDK from 861ebcb175b6 to 1adf3d5fa9d0 (1 revision) (flutter/engine#22636) * 1bf5c8b [web] Implement tilemode for gradient shaders. (flutter/engine#22597) * 97cacfb Add more runtime intrinsic symbols to the export checker script (flutter/engine#22641)

flutter-dashboard bot added the platform-android label Oct 28, 2020

google-cla bot added the cla: yes label Oct 28, 2020

GaryQian force-pushed the splitaotembedder branch from 6883948 to d2eccae Compare October 29, 2020 00:06

GaryQian mentioned this pull request Oct 29, 2020

[WIP] Split AOT Engine changes master #21173

Closed

GaryQian requested review from chinmaygarde, jason-simmons and xster October 29, 2020 00:08

GaryQian force-pushed the splitaotembedder branch 2 times, most recently from b515a4b to 339d75c Compare October 29, 2020 17:45

jason-simmons reviewed Oct 29, 2020

View reviewed changes

GaryQian force-pushed the splitaotembedder branch 3 times, most recently from 3f65733 to bc6f047 Compare October 30, 2020 00:26

xster reviewed Oct 30, 2020

View reviewed changes

GaryQian force-pushed the splitaotembedder branch from 12819ed to a65913b Compare October 30, 2020 07:17

GaryQian force-pushed the splitaotembedder branch from 65ce657 to 587d084 Compare November 5, 2020 06:43

GaryQian force-pushed the splitaotembedder branch from ca22807 to 1a51a4b Compare November 7, 2020 03:07

GaryQian requested a review from xster November 7, 2020 03:10

xster reviewed Nov 9, 2020

View reviewed changes

GaryQian force-pushed the splitaotembedder branch from afc55e8 to 47d9229 Compare November 9, 2020 23:34

xster reviewed Nov 10, 2020

View reviewed changes

flutter-dashboard bot added the platform-ios label Nov 10, 2020

GaryQian mentioned this pull request Nov 10, 2020

Support engine loading dart loading units - AOT split flutter/flutter#62229

Closed

GaryQian force-pushed the splitaotembedder branch 2 times, most recently from d0b4b1c to e2c5858 Compare November 11, 2020 21:09

GaryQian added 14 commits November 19, 2020 11:14

Docs

49a0532

Remove extra imports

20d4e3e

Fix ios and fuchsia tests

b0002e4

Fit x tests

Remove splitcompat

340eb5e

Licenses fix

cfeb109

Fix fuchsia mock

ae7b771

Address docs comments, add destructor

9ed7094

Formatting

eb3ccef

provide DynamicFeatureManager in FlutterLoader

a1c603c

Implement injector

Set JNI in the JNI itself

372adf9

Formatting

e8861b5

Add flutter injector tests

4366c79

Formatting and comment nit

2130d59

More documentation changes

b8cfc01

GaryQian force-pushed the splitaotembedder branch from 0c71f71 to b8cfc01 Compare November 19, 2020 19:16

xster approved these changes Nov 19, 2020

View reviewed changes

GaryQian added 3 commits November 19, 2020 15:20

Address comments

c995673

Formatting

e4e9a1e

FOrmatting

f006e9b

GaryQian added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 20, 2020

GaryQian merged commit 53fc019 into flutter:master Nov 20, 2020

engine-flutter-autoroll mentioned this pull request Nov 20, 2020

Roll Engine from 23a8e027dbbe to 8971b8295fbb (10 revisions) flutter/flutter#70951

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2020

53fc019 Split AOT Android Embedder and shell (flutter/engine#22179)

25d69ad

renyou added a commit that referenced this pull request Nov 20, 2020

Revert "Split AOT Android Embedder and shell (#22179)"

43c08bb

This reverts commit 53fc019.

renyou mentioned this pull request Nov 20, 2020

Revert "Split AOT Android Embedder and shell" #22645

Closed

engine-flutter-autoroll mentioned this pull request Nov 20, 2020

Roll Engine from 23a8e027dbbe to 97cacfbfec89 (14 revisions) flutter/flutter#70958

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2020

53fc019 Split AOT Android Embedder and shell (flutter/engine#22179)

85a44d8

chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020

Split AOT Android Embedder and shell (flutter#22179)

0566b20

GaryQian mentioned this pull request Jan 5, 2021

☂️ Deferred Components: Build and load split AOT Android App Bundles flutter/flutter#57617

Closed

18 tasks

Split AOT Android Embedder and shell #22179

Split AOT Android Embedder and shell #22179

Uh oh!

Conversation

GaryQian commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GaryQian Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xster commented Nov 3, 2020

Uh oh!

xster commented Nov 6, 2020

Uh oh!

GaryQian commented Nov 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GaryQian commented Nov 7, 2020

Uh oh!

xster left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

GaryQian commented Oct 28, 2020 •

edited

Loading

GaryQian Oct 29, 2020 •

edited

Loading

GaryQian commented Nov 6, 2020 •

edited

Loading