Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Dec 21, 2020

Description

These additional files are needed to implement the the accessibility library since we can't use any internal library in engine repository.
They are raw copy of the chromium code and cannot be compiled as-is. This PR means to fork those files into engine repo to serve as the base point to make the future PR easier to review.

Related Issues

Tests

I added the following tests:

files are not compiled

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@google-cla google-cla bot added the cla: yes label Dec 21, 2020
@chunhtai chunhtai requested review from dnfield and gw280 December 21, 2020 19:24
@chunhtai chunhtai force-pushed the additional-chromium branch 2 times, most recently from 942c35c to c9aa061 Compare December 21, 2020 19:41
@chunhtai chunhtai force-pushed the additional-chromium branch from c9aa061 to e6d3bcc Compare December 21, 2020 20:00
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gw280
Copy link
Contributor

gw280 commented Dec 21, 2020

Make sure this is merged using rebase and merge, not squash and merge

@chunhtai chunhtai merged commit 7252263 into flutter:master Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants