This repository was archived by the owner on Feb 25, 2025. It is now read-only.
cache closures from hooks.dart #23230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Dec 22, 2020
| @@ -196,80 +196,109 @@ PlatformConfiguration::PlatformConfiguration( | |||
| PlatformConfiguration::~PlatformConfiguration() {} | |||
|
|
|||
| void PlatformConfiguration::DidCreateIsolate() { | |||
| library_.Set(tonic::DartState::Current(), | |||
| Dart_LookupLibrary(tonic::ToDart("dart:ui"))); | |||
| auto* library = Dart_LookupLibrary(tonic::ToDart("dart:ui")); | |||
There was a problem hiding this comment.
The engine typically declares Dart handles explicitly as type Dart_Handle
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 28, 2020
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids extra calls to
Dart_NewStringFromCString, particularly on_drawFrameand_beginFrame, which are called once per frame. These calls may involve creating a VM safepoint, which ordinarily is cheap but sometimes shows up in traces as taking longer if there is more contention.Related Issues
Fixes flutter/flutter#72117
Tests
Upstream performance tests should be mildly improved by this.