This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll CanvasKit to 0.22 #23348
Merged
Roll CanvasKit to 0.22 #23348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
approved these changes
Jan 5, 2021
yjbanov
reviewed
Jan 6, 2021
yjbanov
reviewed
Jan 6, 2021
| @@ -1269,6 +1292,27 @@ SkFloat32List toMallocedSkPoints(List<ui.Offset> points) { | |||
| return skPoints; | |||
| } | |||
|
|
|||
| /// Converts a list of [ui.Offset] into a flat list of points. | |||
| Float32List toFlatSkPoints(List<ui.Offset> points) { | |||
There was a problem hiding this comment.
Do we still need toSkPoints2d and rawPointsToSkPoints2d after this PR? Also, can we use toMallocedSkPoints instead to avoid double-copying the data?
There was a problem hiding this comment.
I was unsure if that would mean we would have to free and re-malloc the positions whenever we delete the SkVertices. Since we only use it at once, at construction, I figured it wouldn't hurt performance to let CanvasKit do the Malloc.
yjbanov
reviewed
Jan 6, 2021
yjbanov
approved these changes
Jan 6, 2021
harryterkelsen
force-pushed
the
canvaskit-roll-0.22
branch
from
e9ee8e4 to
4e78dc4
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rolls CanvasKit to 0.22, bringing in various fixes.
Related Issues
Fixes flutter/flutter#70620
Tests
Updates
canvaskit_api_test.dartfor APIs that changed.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.