-
Notifications
You must be signed in to change notification settings - Fork 6k
Windows: Add CoreWindow implementation of FlutterWindowsView (Flutter#70205) #23573
Windows: Add CoreWindow implementation of FlutterWindowsView (Flutter#70205) #23573
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
shell/platform/windows/client_wrapper/flutter_view_controller.cc
Outdated
Show resolved
Hide resolved
shell/platform/windows/client_wrapper/include/flutter/dart_project.h
Outdated
Show resolved
Hide resolved
Feedback complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits; looks like we're in good shape for the first step. LGTM with the comments addressed!
To capture from discussion above for posterity: I do think we'll need to rework some things to reduce ifdefing, especially around object constructors, but I think we can iterate on that over time, and where it would affect public API, come up with a migration plan that's more comprehensive when we know more about how the rollout of the UWP option will look.
…#70205) (flutter#23573) * Windows: Add CoreWindow implementation of FlutterWindowsView (Flutter#70205)
Description
This change adds a
CoreWindow
implementation of FlutterWindowView. The UWP target does not yet light up end-to-end with this change.Related Issues
flutter/flutter#70196
flutter/flutter#14967
Tests
I added the following tests:
There is currently no test infrastructure in place for running tests on Windows in AppContainer mode. That will either be added in future commits to this PR or in a future PR
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.- [ ] I updated/added relevant documentation.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.