Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Windows: Add CoreWindow implementation of FlutterWindowsView (Flutter#70205) #23573

Merged
merged 21 commits into from
Jan 27, 2021

Conversation

clarkezone
Copy link

Description

This change adds a CoreWindow implementation of FlutterWindowView. The UWP target does not yet light up end-to-end with this change.

Related Issues

flutter/flutter#70196
flutter/flutter#14967

Tests

I added the following tests:

There is currently no test infrastructure in place for running tests on Windows in AppContainer mode. That will either be added in future commits to this PR or in a future PR

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
    - [ ] I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jan 10, 2021
@clarkezone
Copy link
Author

Feedback complete.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits; looks like we're in good shape for the first step. LGTM with the comments addressed!

To capture from discussion above for posterity: I do think we'll need to rework some things to reduce ifdefing, especially around object constructors, but I think we can iterate on that over time, and where it would affect public API, come up with a migration plan that's more comprehensive when we know more about how the rollout of the UWP option will look.

@clarkezone clarkezone merged commit e005b31 into flutter:master Jan 27, 2021
@clarkezone clarkezone deleted the add-corewindow-backend branch January 27, 2021 05:12
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
…#70205) (flutter#23573)

* Windows: Add CoreWindow implementation of FlutterWindowsView (Flutter#70205)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants