This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Apply font-family and other styles to the paragraph element #23596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
reviewed
Jan 11, 2021
| @@ -8,7 +8,7 @@ import 'package:test/test.dart'; | |||
| import 'package:ui/src/engine.dart'; | |||
| import 'package:ui/ui.dart'; | |||
|
|
|||
| const String paragraphStyle = 'style="position: absolute; white-space: pre-wrap; overflow-wrap: break-word; overflow: hidden;"'; | |||
| const String paragraphStyle = 'font-family: sans-serif; position: absolute; white-space: pre-wrap; overflow-wrap: break-word; overflow: hidden;'; | |||
There was a problem hiding this comment.
do we still need overflow hidden?
There was a problem hiding this comment.
It's only needed for certain cases like when max-lines is set. I'll change it so that the overflow property is only added when needed, instead of all the time.
mdebbar
force-pushed
the
rich_dom_paragraph
branch
from
9d26ef6 to
cdeb1a1
Compare
ferhatb
approved these changes
Jan 11, 2021
mdebbar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply
font-familyand other styles to the root paragraph element. For some reason, even if all the span have the correct font-family, the browser won't render the paragraph correctly unless the root element also has afont-family. This issue seems to only affect the Ahem font in tests for now.Clear the measurement cache when new fonts are loaded. This causes issues occasionally when font loading is delayed or takes longer than expected.