This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Split platforms for clang in DEPS to prepare for autoroller #23810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jan 20, 2021
zanderso
approved these changes
Jan 20, 2021
| @@ -498,14 +498,25 @@ deps = { | |||
| 'dep_type': 'cipd', | |||
| }, | |||
|
|
|||
| 'src/buildtools/{host_os}-x64/clang': { | |||
| 'src/buildtools/mac-x64/clang': { | |||
There was a problem hiding this comment.
Consider adding a comment explaining why they are separate.
dnfield
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
I'm ignoring the timeout and the failure because they're not related to this PR. |
|
Also landed on red to kick the tree, which is hung on an infra failure. This is a very safe patch since it is a no-op refactor. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 21, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
…23810) * Split platforms for clang in DEPS to prepare for autoroller https://bugs.chromium.org/p/skia/issues/detail?id=11197#c3 * Update DEPS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.chromium.org/p/skia/issues/detail?id=11197#c3