This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename TextInputManager to TextInputManagerWin32 #23905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
The current text input manager is win32-specific due to its use of IMM32. For UWP, we'll need a TSF implementation. Once that happens we'll want to extract out a TextInputManager interface and add a separate UWP implementation of this class.
cbracken
force-pushed
the
win32-textinput
branch
from
503ed11 to
bbfb83c
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2021
* 08daa2c Rename TextInputManager to TextInputManagerWin32 (flutter/engine#23905) * 611a8d5 Roll Skia from 069e484cc3b9 to 607a382298b2 (1 revision) (flutter/engine#23907) * aa56ae2 Roll Skia from 607a382298b2 to fe8a4faa4bb2 (4 revisions) (flutter/engine#23910) * 86e05f0 Roll Fuchsia Linux SDK from mrFdelzNr... to GLRm7LJRm... (flutter/engine#23913) * 155827a Roll Skia from fe8a4faa4bb2 to bd91660b6e12 (4 revisions) (flutter/engine#23920) * ef4f5a8 Roll Dart SDK from 2ddf810f71f6 to 70c7daa78288 (1 revision) (flutter/engine#23922) * 790af8a [macos] Support smooth resizing for Metal (flutter/engine#23924) * 2707c21 use a single clang toolchain (flutter/engine#23842) * 523c8c8 Adds a mechanism for announce events to be forwarded to a11y. (flutter/engine#23499) * ee07d1b Roll Skia from bd91660b6e12 to fff4099358bd (9 revisions) (flutter/engine#23929)
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
The current text input manager is win32-specific due to its use of IMM32. For UWP, we'll need a TSF implementation. Once that happens we'll want to extract out a TextInputManager interface and add a separate UWP implementation of this class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current text input manager is win32-specific due to its use of
IMM32. For UWP, we'll need a TSF implementation. Once that happens we'll
want to extract out a TextInputManager interface and add a separate UWP
implementation of this class.
Issues
This is a cleanup patch for #23795 which addressed flutter/flutter#65574: Full IME support for Windows.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.