-
Notifications
You must be signed in to change notification settings - Fork 6k
Grammatical mistake on pull request template #23948
Conversation
I guess it should really be "test-exempt". "tested exempt" would mean that we've tested it in some way, which is the opposite of what this means. :-) |
what about this |
Actually there is no grammatical mistake here. |
@Hixie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, this also exists in flutter/flutter, flutter/plugins, and flutter/packages |
I am not able to find this syntax in flutter/plugins |
It's there, sixth checkbox of https://github.com/flutter/plugins/blob/master/.github/PULL_REQUEST_TEMPLATE.md :-) |
Ah Thank. |
"test exempt" is a compound adjective that is after the noun it is modifying, so this was correct before. |
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.