Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Grammatical mistake on pull request template #23948

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Grammatical mistake on pull request template #23948

merged 2 commits into from
Jan 29, 2021

Conversation

Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Jan 26, 2021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Abhishek01039 Abhishek01039 changed the title Grammatical mistake on pull request temple Grammatical mistake on pull request templet Jan 26, 2021
@Abhishek01039 Abhishek01039 changed the title Grammatical mistake on pull request templet Grammatical mistake on pull request template Jan 26, 2021
@Hixie
Copy link
Contributor

Hixie commented Jan 26, 2021

I guess it should really be "test-exempt". "tested exempt" would mean that we've tested it in some way, which is the opposite of what this means. :-)

@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Jan 26, 2021

what about this
PR test exempt. or PR is testing exempt.
should I add like this?
@Hixie

@thecalamiity
Copy link

Actually there is no grammatical mistake here.

@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Jan 26, 2021

@Hixie
I have changed to this PR is test-exempt (This is ok for you?)
After doing some discussion on discord with @MrBirb.

Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Jan 28, 2021

FWIW, this also exists in flutter/flutter, flutter/plugins, and flutter/packages

@Abhishek01039
Copy link
Contributor Author

I am not able to find this syntax in flutter/plugins
@Hixie

@Hixie
Copy link
Contributor

Hixie commented Jan 28, 2021

It's there, sixth checkbox of https://github.com/flutter/plugins/blob/master/.github/PULL_REQUEST_TEMPLATE.md :-)

@Abhishek01039
Copy link
Contributor Author

Ah Thank.

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 28, 2021
@fluttergithubbot fluttergithubbot merged commit b87307c into flutter:master Jan 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2021
@stuartmorgan-g
Copy link
Contributor

"test exempt" is a compound adjective that is after the noun it is modifying, so this was correct before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants