Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix exception when using a keyboard #24150

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Feb 2, 2021

When the framework doesn't set a listener on key data, we shouldn't try to invoke it with a null zone.

This exception started happening after #23466. There's no need to cherry-pick this PR unless #23466 is cherry-picked.

Fixes flutter/flutter#75076

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Feb 2, 2021
@mdebbar mdebbar requested review from dkwingsmt and ferhatb February 2, 2021 23:33
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt
Copy link
Contributor

Should we cherry pick this?

@mdebbar
Copy link
Contributor Author

mdebbar commented Feb 2, 2021

Should we cherry pick this?

@dkwingsmt Is your PR being cherry-picked?

@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 2, 2021
@dkwingsmt
Copy link
Contributor

Ahh nope. You're right. Nevermind.

@fluttergithubbot fluttergithubbot merged commit b86bc24 into flutter:master Feb 3, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2021
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@mdebbar mdebbar deleted the keyboard_exception branch April 15, 2021 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web]TextformField shows error when trying to type with keyboard
5 participants