Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "[metal] Darwin unified external metal textures (#24157)" #24350

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Reland "[metal] Darwin unified external metal textures (#24157)" #24350

merged 2 commits into from
Feb 11, 2021

Conversation

iskakaushik
Copy link
Contributor

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Feb 11, 2021
@iskakaushik
Copy link
Contributor Author

@chinmaygarde , this is take 2 of my re-land. This time I ran a video for 5 minutes and noticed the memory to be stable. The fix for the leak is in: 870c046 (#24350).

@iskakaushik
Copy link
Contributor Author

Context: flutter/flutter#75802

@iskakaushik iskakaushik merged commit a322e69 into flutter:master Feb 11, 2021
@iskakaushik iskakaushik deleted the rev-ext-tex-part-2 branch February 11, 2021 17:24
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2021
@engine-flutter-autoroll
a322e69 Reland "[metal] Darwin unified external metal textures (flutt…
e61daf0 
…er#24157)" (flutter/engine#24350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2021
@engine-flutter-autoroll
a322e69 Reland "[metal] Darwin unified external metal textures (flutt…
c67b25c 
…er#24157)" (flutter/engine#24350)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@iskakaushik @hjfreyer
Reland "[metal] Darwin unified external metal textures (flutter#24157)…
12b2a43 
…" (flutter#24350)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskakaushik @chinmaygarde @googlebot