Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Fix origin for repeated linear gradients #24354

Merged
merged 9 commits into from
Feb 17, 2021
Merged

[web] Fix origin for repeated linear gradients #24354

merged 9 commits into from
Feb 17, 2021

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Feb 11, 2021

This PR fixes the origin of repeated linear gradients. A prior attempt at problem was #23691. However it centered the gradient incorrectly at mid point of from/to vector instead of center of shader bounds. This PR removes the shiftOrigin special case and instead fixes the gl_FragCoord matrix.

flutter/flutter#74137

Added new test case in gradient_golden_test.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

@ferhatb ferhatb requested a review from yjbanov February 11, 2021 21:07
yjbanov
yjbanov approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chinmaygarde chinmaygarde added the platform-web Code specifically for the web engine label Feb 11, 2021
@ferhatb ferhatb added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 17, 2021
@ferhatb ferhatb merged commit 3bd0e68 into flutter:master Feb 17, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
24cd689 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
6b51c8e 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
d95aafe 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
e12d044 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
bb9d025 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
bff2464 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
c6458c7 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
72d04e5 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
e0317cd 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
b78f198 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
b59d838 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
df3430a 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
d9272f6 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
98f6e7e 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
8a757f7 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
497b71e 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
197463d 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
1c47d59 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
1c658ee 
…e#24354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
3bd0e68 [web] Fix origin for repeated linear gradients (flutter/engin…
2f8574b 
…e#24354)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@ferhatb @hjfreyer
[web] Fix origin for repeated linear gradients (flutter#24354)
df55d75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferhatb @yjbanov @chinmaygarde @googlebot