Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add missing header guard, namespace #24423

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Add missing header guard, namespace #24423

merged 1 commit into from
Feb 15, 2021

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Feb 15, 2021 •
edited
Loading

TextRange was missing a namespace declaration and header guards.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Feb 15, 2021
@cbracken cbracken force-pushed the missing-header-guard branch from f9f215d to f9cda0b Compare February 15, 2021 19:45
stuartmorgan-g
stuartmorgan-g approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken
Add missing header guard, namespace
1ffd44b 
TextRange was missing a namespace declaration and header guards.
@cbracken cbracken force-pushed the missing-header-guard branch from f9cda0b to 1ffd44b Compare February 15, 2021 19:53
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cbracken cbracken merged commit 0561a98 into flutter:master Feb 15, 2021
@cbracken cbracken deleted the missing-header-guard branch February 15, 2021 21:26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
5a97964
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
f96cdc7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
40a087f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
f411331
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
7ec7dcf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
cb4e668
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
76160bf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
d5b025e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
fe5b515
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
0561a98 Add missing header guard, namespace (flutter/engine#24423)
53d9a20
zanderso pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2021
@engine-flutter-autoroll
Roll Engine from 1d53782 to 6993cb2 (45 revisions) (#76151)
311fac4 
* 1dc8695 Replace Flutter surface only after all platform views are destroyed (flutter/engine#24363)

* 0d4accf Roll Skia from ec24154521f3 to 28698696f1b3 (4 revisions) (flutter/engine#24374)

* 454a34f [canvaskit] support adding leaf layers w/o container layers (flutter/engine#24357)

* 2edeb47 Roll Dart SDK from 1e0fec6e48cf to add1eac3622c (1 revision) (flutter/engine#24375)

* 7376d18 Roll Skia from 28698696f1b3 to 3354f8c4f8cb (2 revisions) (flutter/engine#24378)

* 157797e Fix vulkan surface leaks. (flutter/engine#24372)

* 72ed416 Roll Skia from 3354f8c4f8cb to 2494942f0d8d (4 revisions) (flutter/engine#24380)

* 6747b83 Roll Skia from 2494942f0d8d to 6e73404a782c (3 revisions) (flutter/engine#24383)

* 48cf2b9 [canvaskit] fix Path.from (flutter/engine#24382)

* 42019c8 Roll Fuchsia Linux SDK from YMY-cajLa... to AjjJVX_95... (flutter/engine#24381)

* c3f0894 Roll Skia from 6e73404a782c to ba4c3086ba80 (3 revisions) (flutter/engine#24388)

* 4f33430 Roll Dart SDK from add1eac3622c to 6eafd1856eb5 (1 revision) (flutter/engine#24390)

* 7661388 Roll Fuchsia Mac SDK from WIqUEANCH... to yyQmi032P... (flutter/engine#24391)

* 6b33d4e Roll Skia from ba4c3086ba80 to 4f065e286df6 (2 revisions) (flutter/engine#24393)

* 623d9ce Windows: linker compatibility with AppContainer for winuwp target (flutter/engine#24318)

* 89c8b6e Roll Dart SDK from 6eafd1856eb5 to e9693f1b2401 (1 revision) (flutter/engine#24394)

* 447733c Roll Fuchsia Linux SDK from AjjJVX_95... to uJ8jPHroy... (flutter/engine#24395)

* 7b1efcf Roll Fuchsia Mac SDK from yyQmi032P... to NQL9o1B8n... (flutter/engine#24396)

* 08dcad7 Roll Dart SDK from e9693f1b2401 to 4c8147b7b41e (1 revision) (flutter/engine#24397)

* 102cb3c Roll Skia from 4f065e286df6 to 554aabbaa8e8 (1 revision) (flutter/engine#24398)

* 780ba15 Roll Dart SDK from 4c8147b7b41e to 56fa015ca3ec (1 revision) (flutter/engine#24402)

* 9286135 Roll Skia from 554aabbaa8e8 to 7a2ff98ce68b (1 revision) (flutter/engine#24403)

* 95cc4ce Roll buildroot to e7857d2 (flutter/engine#24399)

* 9bc4bf1 Revert "Roll buildroot to e7857d2 (#24399)"

* b8126b6 Roll Skia from 7a2ff98ce68b to c3e152b9f795 (2 revisions) (flutter/engine#24404)

* cfdbd16 Roll Dart SDK from 56fa015ca3ec to c9b47adb178e (1 revision) (flutter/engine#24408)

* 6ece8d1 Roll Fuchsia Mac SDK from NQL9o1B8n... to OHm_snJzB... (flutter/engine#24410)

* e3d05a1 Roll Fuchsia Linux SDK from uJ8jPHroy... to JmB58d-3R... (flutter/engine#24411)

* 491eeeb Roll Skia from c3e152b9f795 to b44fbb3392f8 (3 revisions) (flutter/engine#24414)

* 2349ee9 Roll Skia from b44fbb3392f8 to 56a8fbd21ee2 (3 revisions) (flutter/engine#24415)

* cce0869 Roll Dart SDK from c9b47adb178e to 648d5f951915 (1 revision) (flutter/engine#24416)

* 138ec27 Roll Skia from 56a8fbd21ee2 to 7cb0f6e9702a (1 revision) (flutter/engine#24418)

* dbded38 Roll Fuchsia Mac SDK from OHm_snJzB... to H0v5Ox4Vs... (flutter/engine#24419)

* 05347d4 Roll Fuchsia Linux SDK from JmB58d-3R... to KKD5xVYLO... (flutter/engine#24420)

* 5659b56 Roll Dart SDK from 648d5f951915 to 39dc63439396 (1 revision) (flutter/engine#24421)

* 0561a98 Add missing header guard, namespace (flutter/engine#24423)

* 3e91ee2 Adjust header guards for updated paths (flutter/engine#24424)

* d71c030 Roll Skia from 7cb0f6e9702a to 330578e81158 (1 revision) (flutter/engine#24427)

* dcb0c0f Roll Fuchsia Mac SDK from H0v5Ox4Vs... to eG4TqZBn9... (flutter/engine#24425)

* d7705f9 Roll Fuchsia Linux SDK from KKD5xVYLO... to C2FaCuCLB... (flutter/engine#24430)

* e1f03cd Roll Dart SDK from 39dc63439396 to 4db0f5599c85 (1 revision) (flutter/engine#24431)

* 1687040 [Android Text Input] Remove Samsung restart input workaround for newer Samsung keyboards (flutter/engine#24288)

* bee0d2a Roll Skia from 330578e81158 to 4a3ec173b31b (5 revisions) (flutter/engine#24434)

* 8490ec2 [ci] Remove null safety experiment flag (flutter/engine#24392)

* 6993cb2 Revert Dart SDK to 1e0fec6e48cf89f46973af38a5c2de4bc760a135 (flutter/engine#24436)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@cbracken @hjfreyer
Add missing header guard, namespace (flutter#24423)
c83e700 
TextRange was missing a namespace declaration and header guards.
@swift-kim swift-kim mentioned this pull request Jun 7, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@clarkezone clarkezone Awaiting requested review from clarkezone

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
affects: desktop affects: engine affects: text input cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbracken @stuartmorgan-g