This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix input flow event logic #24526
Merged
Fix input flow event logic #24526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to handle the case of touch events that do not lead to frames. Previously, all touch event flow ids were queued in |Animator| until a frame was created, and then flowed into that frame. For no frame touch events, this would then cause metrics and trace visualization to erroneously associate the eventual frame with the original touch events. This issue is fixed by extending the Animator/VsyncWaiter's secondary vsync callback mechanism to support additional callbacks, and then using a secondary vsync callback to drain/end touch flow events when frames finish and no further frames are scheduled. Also add an additional flow step to |SmoothPointerDataDispatcher::DispatchPacket|. b/177250670
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 25, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 25, 2021
* 4f660da Roll Dart SDK from 63c6585d8499 to 6b7054122356 (1 revision) (flutter/engine#24625) * 25887bc Roll Skia from e79bb32365ea to 4ac9aadd306b (4 revisions) (flutter/engine#24630) * 1bdf5d3 TextStyle level leadingDistribution (flutter/engine#24025) * c4678d6 Fix input flow event logic (flutter/engine#24526)
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to handle the case of touch events that do not lead to frames.
Previously, all touch event flow ids were queued in |Animator| until a frame
was created, and then flowed into that frame. For no frame touch
events, this would then cause metrics and trace visualization to erroneously
associate the eventual frame with the original touch events. This issue
is fixed by extending the Animator/VsyncWaiter's secondary vsync
callback mechanism to support additional callbacks, and then using a
secondary vsync callback to drain/end touch flow events when frames
finish and no further frames are scheduled.
Also add an additional flow step to
|SmoothPointerDataDispatcher::DispatchPacket|.
b/177250670
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.