This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Added dependency on CppWinRT for UWP builds #24770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CppWinRT is a tool that generates standard C++17 header-file libraries for Windows Runtime (WinRT) APIs. A more detailed introduction to C++/WinRT can be found in the Microsoft documentation at https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/. The source code is available under an MIT license, from https://github.com/microsoft/cppwinrt. Bug: flutter/flutter#70205
jason-simmons
approved these changes
Mar 4, 2021
clarkezone
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
LGTM. Confirmed that the tool binaries work as expected. There is one caveat: there is a potential bug in the generated output of the tool that I thought had been fixed. Need to confirm that it is still a problem (std::terminate() not working as expected; fixed using abort() instead); if that is the case we'll need to re-ingest tool once the fix is in.
|
Sounds good. This was a build released on 2021-03-01. If it's been fixed more recently it'll be easy to re-bundle as soon as the new build is up on nuget. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 4, 2021
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 4, 2021
* aa3bb5e [web] Fix painting of last placeholder in paragraph (flutter/engine#24716) * a5ae18b [web] Fix pointer events for Wacom pen (flutter/engine#24719) * 4993c8e Roll Skia from d863ae52d4bb to 036ba86489d7 (3 revisions) (flutter/engine#24732) * 7f1de85 Roll Dart SDK from f209e60a5415 to 761ed531161f (1 revision) (flutter/engine#24730) * 44ba1cc Roll Skia from 036ba86489d7 to 786d42c6dac4 (1 revision) (flutter/engine#24733) * 735876e Fix memory leak and bug in the RunsOnCreationTaskRunner check (flutter/engine#24690) * 454d29c Roll Skia from 786d42c6dac4 to 12e760e958a7 (10 revisions) (flutter/engine#24738) * 2c605fd Roll Fuchsia Linux SDK from tJbtmEE4Q... to YhRvbuj9c... (flutter/engine#24739) * bf97442 Roll Skia from 12e760e958a7 to e80e169ba4c1 (1 revision) (flutter/engine#24740) * 4d2caac Fix UWP build for UpdateCursorRect rename (flutter/engine#24697) * 83b2f8f Roll Fuchsia Mac SDK from PRe0w0i4z... to 4TE5n81B-... (flutter/engine#24745) * 410dd6f Roll Dart SDK from 761ed531161f to f527ddd39bb1 (3 revisions) (flutter/engine#24746) * 91d9278 Roll Dart SDK from f527ddd39bb1 to 041a6dd2e76b (1 revision) (flutter/engine#24749) * 03e0a11 Roll Fuchsia Linux SDK from YhRvbuj9c... to _0kewDFPJ... (flutter/engine#24750) * f5b1351 Roll Skia from e80e169ba4c1 to acf26501fb5a (4 revisions) (flutter/engine#24752) * 21de22a Roll Skia from acf26501fb5a to a1e30a3a280a (5 revisions) (flutter/engine#24753) * e29fd6d Roll Fuchsia Mac SDK from 4TE5n81B-... to kPp_BF0q3... (flutter/engine#24759) * de78d2a Roll Skia from a1e30a3a280a to f0de96f7b82a (7 revisions) (flutter/engine#24760) * a33687d Roll Skia from f0de96f7b82a to 46d9bb255df4 (2 revisions) (flutter/engine#24762) * 95215b7 Roll Dart SDK from 041a6dd2e76b to b9302efc8d9a (3 revisions) (flutter/engine#24764) * 4aeffbe Move CIPD package creation tools under tools/cipd (flutter/engine#24766) * 8ef7b63 Roll Skia from 46d9bb255df4 to e4ef35caa1bc (9 revisions) (flutter/engine#24769) * 4bef5f8 Enables semantics when voice control is turned on (flutter/engine#24640) * a546f16 Roll Fuchsia Linux SDK from _0kewDFPJ... to _vRi_XkB7... (flutter/engine#24771) * e31cdad Added dependency on CppWinRT for UWP builds (flutter/engine#24770) * a5ba994 Roll Skia from e4ef35caa1bc to 4db57264955f (1 revision) (flutter/engine#24772) * 3cf4f1d Revert "[web] Fix painting of last placeholder in paragraph (#24716)" (flutter/engine#24773) * 91120b3 Roll Skia from 4db57264955f to 21c8ad62cd82 (2 revisions) (flutter/engine#24774)
|
The clang issues are now fixed in https://github.com/microsoft/cppwinrt/releases/tag/2.0.210304.5 @cbracken clear to update the package. |
|
Consuming this with: |
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
CppWinRT is a tool that generates standard C++17 header-file libraries for Windows Runtime (WinRT) APIs. A more detailed introduction to C++/WinRT can be found in the Microsoft documentation at https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/. The source code is available under an MIT license, from https://github.com/microsoft/cppwinrt. Bug: flutter/flutter#70205
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
CppWinRT is a tool that generates standard C++17 header-file libraries for Windows Runtime (WinRT) APIs. A more detailed introduction to C++/WinRT can be found in the Microsoft documentation at https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/. The source code is available under an MIT license, from https://github.com/microsoft/cppwinrt. Bug: flutter/flutter#70205
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CppWinRT is a tool that generates standard C++17 header-file libraries
for Windows Runtime (WinRT) APIs. A more detailed introduction to
C++/WinRT can be found in the Microsoft documentation at
https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/.
The source code is available under an MIT license, from
https://github.com/microsoft/cppwinrt.
Bug: flutter/flutter#70205
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.