Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Reland: Fix painting of last placeholder in paragraph #24905

Merged
merged 4 commits into from
Mar 10, 2021
Merged

[web] Reland: Fix painting of last placeholder in paragraph #24905

merged 4 commits into from
Mar 10, 2021

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 10, 2021 •
edited
Loading

Initially landed in: #24716
Reverted in: #24773

This PR contains an additional commit that fixes the failure that caused it to be reverted. It also adds a test in the engine to catch that failure earlier next time.

Updated screenshots: flutter/goldens#182

Fixes flutter/flutter#76122

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Mar 10, 2021
@google-cla google-cla bot added the cla: yes label Mar 10, 2021
@mdebbar mdebbar mentioned this pull request Mar 10, 2021
Merged
@mdebbar mdebbar requested a review from ferhatb March 10, 2021 20:12
@mdebbar mdebbar marked this pull request as ready for review March 10, 2021 21:13
@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 10, 2021
@fluttergithubbot fluttergithubbot merged commit c1ada67 into flutter:master Mar 10, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2021
@engine-flutter-autoroll
c1ada67 [web] Reland: Fix painting of last placeholder in paragraph (f…
6e8ed0f 
…lutter/engine#24905)
@mdebbar mdebbar mentioned this pull request Mar 19, 2021
Closed
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@mdebbar @hjfreyer
[web] Reland: Fix painting of last placeholder in paragraph (flutter#…
977201f 
…24905)
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@mdebbar @chriscraws
[web] Reland: Fix painting of last placeholder in paragraph (flutter#…
30c4f28 
…24905)
christopherfujino added a commit that referenced this pull request Mar 31, 2021
@christopherfujino @mdebbar
[flutter_releases] Flutter Stable 2.0.4 Engine Cherrypicks (#25341)
2dce470 
* [web] Fix right click issue when dragging (#24447)
* [web] Fix placeholder-only paragraphs (#24572)
* [web] Reland: Fix painting of last placeholder in paragraph (#24905)

Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
@mdebbar mdebbar deleted the fix_revert_last_placeholder branch April 15, 2021 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ferhatb ferhatb ferhatb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web HTML renderer does not work with widgetspans
3 participants
@mdebbar @ferhatb @fluttergithubbot