This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename moduleName to componentName for consistency
#24906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingjun
approved these changes
Mar 10, 2021
| * loadingUnitId larger than the highest valid loading unit's id will cause the Dart | ||
| * loadLibrary() to complete with a failure. | ||
| * @param moduleName The deferred component module name as defined in bundle_config.yaml. This may | ||
| * @param componentName The deferred component component name as defined in bundle_config.yaml. This may |
There was a problem hiding this comment.
Nit: "deferred component component name" should either be "name of the deferred component" or just "deferred component name"?
Same for the other files.
There was a problem hiding this comment.
Ahh I fixed a few of these, but also missed a few, thanks for the catch.
GaryQian
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames all instances of
moduleNametocomponentNameto avoid referencing android modules, which is play store implementation specific. Instead, we refer to it bycomponentNamewhich is a flutter concept and is equivalent to the android module name in the default implementation.