Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[fuchsia] Populates fuchsia node is_keyboard_key in accessibility bridge #25334

Merged
merged 1 commit into from
Apr 1, 2021
Merged

[fuchsia] Populates fuchsia node is_keyboard_key in accessibility bridge #25334

merged 1 commit into from
Apr 1, 2021

Conversation

abrush21
Copy link
Contributor

This change sets the fuchsia node attribute is_keyboard_key in the accessibility bridge.

List which issues are fixed by this PR. You must list at least one issue.
fxb/71376

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@abrush21
[fuchsia] Populates fuchsia node is_keyboard_key in accessibility bri…
9a80ca2 
…dge.

This change sets the fuchsia node attribute is_keyboard_key in the
accessibility bridge.
@google-cla google-cla bot added the cla: yes label Mar 31, 2021
@abrush21 abrush21 marked this pull request as ready for review March 31, 2021 19:05
chunhtai
chunhtai approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai merged commit 1eaef55 into flutter:master Apr 1, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2021
@engine-flutter-autoroll
1eaef55 [fuchsia] Populates fuchsia node is_keyboard_key in accessibi…
287c957 
…lity bridge. (flutter/engine#25334)
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@abrush21 @duanqz
[fuchsia] Populates fuchsia node is_keyboard_key in accessibility bri…
f6ceb9a 
…dge. (flutter#25334)

This change sets the fuchsia node attribute is_keyboard_key in the
accessibility bridge.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@chunhtai chunhtai chunhtai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrush21 @chunhtai