Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Fix some regex issues in the sdk_rewriter #25866

Merged
merged 1 commit into from
May 3, 2021
Merged

[web] Fix some regex issues in the sdk_rewriter #25866

merged 1 commit into from
May 3, 2021

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Apr 30, 2021 •
edited
Loading

  • Handle extra whitespaces in source files correctly (@ferhatb's issue).
  • Rewrite correctly when the part directive is at the top of the file (@ditman's issue).
  • Add a few tests (@jonahwilliams's request).

flutter/flutter#80755

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Apr 30, 2021
@google-cla google-cla bot added the cla: yes label Apr 30, 2021
ditman
ditman approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the missing copyright detection feature :P

jonahwilliams
jonahwilliams approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar merged commit d61bbfa into flutter:master May 3, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2021
@engine-flutter-autoroll
d61bbfa [web] Fix some regex issues in the sdk_rewriter (flutter/engi…
957c6ac 
…ne#25866)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2021
@engine-flutter-autoroll
d61bbfa [web] Fix some regex issues in the sdk_rewriter (flutter/engi…
be3e7b9 
…ne#25866)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 4, 2021
@engine-flutter-autoroll
d61bbfa [web] Fix some regex issues in the sdk_rewriter (flutter/engi…
1ddebe9 
…ne#25866)
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request May 5, 2021
@mdebbar @gspencergoog
[web] Fix some regex issues in the sdk_rewriter (flutter#25866)
acfbffb
@mdebbar mdebbar mentioned this pull request Dec 2, 2021
Merged
@mdebbar mdebbar deleted the fix_sdk_rewriter branch January 17, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@ferhatb ferhatb ferhatb approved these changes

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdebbar @ditman @ferhatb @jonahwilliams